From d10f55c3e93fcb4b24fbc92f6dd4bf31f5c8ef82 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Thu, 28 Nov 2019 16:38:26 +1100 Subject: [PATCH] Revert "FIX: adds data-topic-id to quick-access-item (#8422)" This reverts commit 700bd280e45de7811145aca609847f84e4219c35. Oops looks like this breaks tests: ``` Module Failed: widget:quick-access-item Test Failed: escapedContent attribute is not escaped Assertion Failed: TypeError: Cannot read property 'match' of undefined Expected: true, Actual: false Test Failed: anonymous Assertion Failed: failed, expected argument to be truthy, was: 0 Expected: true, Actual: 0 Assertion Failed: Element .enable-anonymous not found. Test Failed: anonymous - switch back Assertion Failed: failed, expected argument to be truthy, was: 0 Expected: true, Actual: 0 Assertion Failed: Element .disable-anonymous not found. Test Failed: log out Assertion Failed: failed, expected argument to be truthy, was: 0 Expected: true, Actual: 0 Assertion Failed: Element .logout not found. Test Failed: content attribute is escaped Assertion Failed: TypeError: Cannot read property 'match' of undefined Expected: true, Actual: false ``` --- .../discourse/widgets/quick-access-item.js.es6 | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/app/assets/javascripts/discourse/widgets/quick-access-item.js.es6 b/app/assets/javascripts/discourse/widgets/quick-access-item.js.es6 index a9c27067694..a37200e5956 100644 --- a/app/assets/javascripts/discourse/widgets/quick-access-item.js.es6 +++ b/app/assets/javascripts/discourse/widgets/quick-access-item.js.es6 @@ -33,19 +33,11 @@ createWidget("quick-access-item", { return result; }, - html({ href, icon }) { - let content = this._contentHtml(); - - let topicId = href.match(/\/t\/.*?\/(\d+)/); - if (topicId && topicId[1]) { - topicId = escapeExpression(topicId[1]); - content = `${content}`; - } - + html({ icon, href }) { return h("a", { attributes: { href } }, [ iconNode(icon), new RawHtml({ - html: `
${this._usernameHtml()}${content}
` + html: `
${this._usernameHtml()}${this._contentHtml()}
` }) ]); },