IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Unread group PMs should use GroupUser#first_unread_pm_at. (#14075)

Browse Source 
This bug was causing unread PMs for groups to appear inaccurate.
This commit is contained in:
Alan Guo Xiang Tan
2021-08-18 11:23:28 +08:00
committed by GitHub
parent 3d92555f7a
commit d13716286c
2 changed files with 36 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
spec/lib/topic_query/private_message_lists_spec.rb
View File

@@ -111,16 +111,26 @@ describe TopicQuery::PrivateMessageLists do
end
describe '#list_private_messages_all_unread' do
it 'returns a list of unread private messages' do
topics = TopicQuery.new(nil).list_private_messages_all_unread(user_2).topics
expect(topics).to eq([])
before do
TopicUser.find_by(user: user_2, topic: group_message).update!(
last_read_post_number: 1
)
create_post(user: user, topic: group_message)
end
it 'returns a list of unread private messages' do
topics = TopicQuery.new(nil).list_private_messages_all_unread(user_2).topics
expect(topics).to contain_exactly(group_message)
end
it 'takes into account first_unread_pm_at optimization' do
user_2.user_stat.update!(first_unread_pm_at: group_message.created_at + 1.day)
GroupUser.find_by(user: user_2, group: group).update!(
first_unread_pm_at: group_message.created_at - 1.day
)
topics = TopicQuery.new(nil).list_private_messages_all_unread(user_2).topics