IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

REFACTOR: steps controller specs to requests

Browse Source
This commit is contained in:
OsamaSayegh 2018-06-06 12:49:43 +03:00 committed by Guo Xiang Tan
parent 47ddb3a7ca
commit d2880246cd
1 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
spec/controllers/steps_controller_spec.rb → spec/requests/steps_controller_spec.rb
View File

@ -1,57 +1,55 @@
require 'rails_helper' require 'rails_helper'
describe StepsController do describe StepsController do
before do before do
SiteSetting.wizard_enabled = true SiteSetting.wizard_enabled = true
end end
it 'needs you to be logged in' do it 'needs you to be logged in' do
put :update, params: { put "/wizard/steps/made-up-id.json", params: {
id: 'made-up-id', fields: { forum_title: "updated title" } fields: { forum_title: "updated title" }
}, format: :json }
expect(response.status).to eq(403) expect(response.status).to eq(403)
end end
it "raises an error if you aren't an admin" do it "raises an error if you aren't an admin" do
log_in(:moderator) sign_in(Fabricate(:moderator))
put :update, params: { put "/wizard/steps/made-up-id.json", params: {
id: 'made-up-id', fields: { forum_title: "updated title" } fields: { forum_title: "updated title" }
}, format: :json }
expect(response).to be_forbidden expect(response).to be_forbidden
end end
context "as an admin" do context "as an admin" do
before do before do
log_in(:admin) sign_in(Fabricate(:admin))
end end
it "raises an error if the wizard is disabled" do it "raises an error if the wizard is disabled" do
SiteSetting.wizard_enabled = false SiteSetting.wizard_enabled = false
put :update, params: { put "/wizard/steps/contact.json", params: {
id: 'contact', fields: { contact_email: "eviltrout@example.com" } fields: { contact_email: "eviltrout@example.com" }
}, format: :json }
expect(response).to be_forbidden expect(response).to be_forbidden
end end
it "updates properly if you are staff" do it "updates properly if you are staff" do
put :update, params: { put "/wizard/steps/contact.json", params: {
id: 'contact', fields: { contact_email: "eviltrout@example.com" } fields: { contact_email: "eviltrout@example.com" }
}, format: :json }
expect(response).to be_successful expect(response).to be_successful
expect(SiteSetting.contact_email).to eq("eviltrout@example.com") expect(SiteSetting.contact_email).to eq("eviltrout@example.com")
end end
it "returns errors if the field has them" do it "returns errors if the field has them" do
put :update, params: { put "/wizard/steps/contact.json", params: {
id: 'contact', fields: { contact_email: "not-an-email" } fields: { contact_email: "not-an-email" }
}, format: :json }
expect(response).to_not be_successful expect(response.status).to eq(422)
end end
end end
end end