From d35633deabef29b090c2e7e86d8e3db1cf45374e Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Wed, 20 Aug 2014 15:12:18 -0400 Subject: [PATCH] FIX: Using a binding in an `{{avatar}}` was broken --- .../javascripts/admin/templates/flags.js.handlebars | 10 ++-------- .../javascripts/discourse/helpers/user-avatar.js.es6 | 7 +++---- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/app/assets/javascripts/admin/templates/flags.js.handlebars b/app/assets/javascripts/admin/templates/flags.js.handlebars index 320ec0d7fdf..5c1c2a2c2cc 100644 --- a/app/assets/javascripts/admin/templates/flags.js.handlebars +++ b/app/assets/javascripts/admin/templates/flags.js.handlebars @@ -28,14 +28,8 @@ {{#if flaggedPost.postAuthorFlagged}} {{#if flaggedPost.user}} - {{#with flaggedPost}} - {{#link-to 'adminUser' user}} - {{avatar user imageSize="small"}} - {{/link-to}} - {{#if wasEdited}} - - {{/if}} - {{/with}} + {{#link-to 'adminUser' flaggedPost.user}}{{avatar flaggedPost.user imageSize="small"}}{{/link-to}} + {{#if flaggedPost.wasEdited}}{{/if}} {{/if}} {{/if}} diff --git a/app/assets/javascripts/discourse/helpers/user-avatar.js.es6 b/app/assets/javascripts/discourse/helpers/user-avatar.js.es6 index 12ce28d8f0d..675bc9a35c3 100644 --- a/app/assets/javascripts/discourse/helpers/user-avatar.js.es6 +++ b/app/assets/javascripts/discourse/helpers/user-avatar.js.es6 @@ -1,10 +1,6 @@ export function renderAvatar(user, options) { options = options || {}; - if (typeof user === 'string') { - user = Ember.Handlebars.get(this, user, options); - } - if (user) { var username = Em.get(user, 'username'); if (!username) username = Em.get(user, options.usernamePath); @@ -41,5 +37,8 @@ export function renderAvatar(user, options) { } Handlebars.registerHelper('avatar', function(user, options) { + if (typeof user === 'string') { + user = Ember.Handlebars.get(this, user, options); + } return new Handlebars.SafeString(renderAvatar.call(this, user, options.hash)); });