IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-20 11:48:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Avoid waiting full Capbyara default wait timeout in system tests (#22684)

Browse Source 
Avoid using negated matchers with custom RSpec matchers that rely on
`has_css?` as it'll result in Capybara waiting the full default wait
time.
This commit is contained in:
Alan Guo Xiang Tan 2023-07-19 14:23:43 +08:00 committed by GitHub
parent 77b4e42f61
commit d753e00eb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spec/system/page_objects/pages/review.rb
View File

@ -46,6 +46,10 @@ module PageObjects
page.has_css?(REVIEWABLE_ACTION_DROPDOWN)
end
def has_no_reviewable_action_dropdown?
page.has_no_css?(REVIEWABLE_ACTION_DROPDOWN)
end
def has_reviewable_with_pending_status?(reviewable)
within(reviewable_by_id(reviewable.id)) { page.has_css?(".status .pending") }
end
@ -59,7 +63,7 @@ module PageObjects
end
def has_no_error_dialog_visible?
!has_error_dialog_visible?
page.has_no_css?("dialog-container .dialog-content")
end
private

2
spec/system/reviewables_spec.rb
View File

@ -48,7 +48,7 @@ describe "Reviewables", type: :system do
expect(review_page).to have_no_error_dialog_visible
expect(review_page).to have_reviewable_with_rejected_status(queued_post_reviewable)
expect(review_page).not_to have_reviewable_action_dropdown
expect(review_page).to have_no_reviewable_action_dropdown
expect(queued_post_reviewable.reload).to be_rejected
expect(queued_post_reviewable.target_created_by).to be_nil
end