IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Better warning message if defaultState is used improperly

Browse Source
This commit is contained in:
Robin Ward 2016-04-27 15:06:55 -04:00
parent 55ba81494f
commit d89fb6e83e
No known key found for this signature in database
GPG Key ID: 0E091E2B4ED1B83D
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/assets/javascripts/discourse/widgets/widget.js.es6
View File

@ -125,8 +125,11 @@ export default class Widget {
this.key = this.buildKey ? this.buildKey(attrs) : null; this.key = this.buildKey ? this.buildKey(attrs) : null;
// Helps debug widgets // Helps debug widgets
if (Ember.Test) { if (Ember.testing) {
if (Object.keys(this.defaultState(attrs)).length > 0 && !this.key) { const ds = this.defaultState(attrs);
if (typeof ds !== "object") {
Ember.warn(`defaultState must return an object`);
} else if (Object.keys(ds).length > 0 && !this.key) {
Ember.warn(`you need a key when using state ${this.name}`); Ember.warn(`you need a key when using state ${this.name}`);
} }
} }