IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: gives aria-label to topics count in category-row (#7307)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2019-04-02 17:38:21 +02:00 committed by GitHub
parent e77b1cf7ff
commit d8dd130477
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/select-kit/components/category-row.js.es6
View File

@ -75,7 +75,7 @@ export default SelectKitRowComponent.extend({
"options.countSubcategories" "options.countSubcategories"
) )
topicCount(totalCount, topicCount, countSubcats) { topicCount(totalCount, topicCount, countSubcats) {
return `× ${countSubcats ? totalCount : topicCount}`.htmlSafe(); return countSubcats ? totalCount : topicCount;
}, },
@computed("displayCategoryDescription", "category.description") @computed("displayCategoryDescription", "category.description")

8
app/assets/javascripts/select-kit/templates/components/category-row.hbs
View File

@ -5,12 +5,16 @@
{{badgeForParentCategory}} {{badgeForParentCategory}}
{{/unless}} {{/unless}}
{{badgeForCategory}} {{badgeForCategory}}
<span class="topic-count">{{topicCount}}</span> <span class="topic-count" aria-label={{i18n "category_row.topic_count" count=topicCount}}>
&times; {{topicCount}}
</span>
</div> </div>
{{else}} {{else}}
<div class="category-status"> <div class="category-status">
{{badgeForCategory}} {{badgeForCategory}}
<span class="topic-count">{{topicCount}}</span> <span class="topic-count" aria-label={{i18n "category_row.topic_count" count=topicCount}}>
&times; {{topicCount}}
</span>
</div> </div>
{{/if}} {{/if}}

3
config/locales/client.en.yml
View File

@ -1429,6 +1429,9 @@ en:
conditional_loading_section: conditional_loading_section:
loading: Loading... loading: Loading...
category_row:
topic_count: "{{count}} topics in this category"
select_kit: select_kit:
default_header_text: Select... default_header_text: Select...
no_content: No matches found no_content: No matches found