From d940a8e41a2317af921badd8f190ab097a047b1a Mon Sep 17 00:00:00 2001 From: Bianca Nenciu Date: Tue, 21 Sep 2021 15:51:29 +0300 Subject: [PATCH] DEV: Use a better selector for search menu (#14390) ".search-menu" matches the parent element of the element that was previously selected. This is a better choice because it offers some flexibility over the DOM structure without breaking the keyboard shortcuts. --- .../javascripts/discourse/app/widgets/search-menu.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/discourse/app/widgets/search-menu.js b/app/assets/javascripts/discourse/app/widgets/search-menu.js index 3463070b575..6e7799d4599 100644 --- a/app/assets/javascripts/discourse/app/widgets/search-menu.js +++ b/app/assets/javascripts/discourse/app/widgets/search-menu.js @@ -332,14 +332,14 @@ export default createWidget("search-menu", { const up = e.which === 38; const down = e.which === 40; if (up || down) { - let focused = $("header .panel-body *:focus")[0]; + let focused = $(".search-menu *:focus")[0]; if (!focused) { return; } - let links = $("header .panel-body .results a"); - let results = $("header .panel-body .results .search-link"); + let links = $(".search-menu .results a"); + let results = $(".search-menu .results .search-link"); let prevResult; let result; @@ -361,9 +361,9 @@ export default createWidget("search-menu", { } if (index === -1 && down) { - $("header .panel-body .search-link:first").focus(); + $(".search-menu .search-link:first").focus(); } else if (index === 0 && up) { - $("header .panel-body input:first").focus(); + $(".search-menu input:first").focus(); } else if (index > -1) { index += down ? 1 : -1; if (index >= 0 && index < results.length) {