From da2b0b2882f5fa9ea4903ad183f1f8e1bf708471 Mon Sep 17 00:00:00 2001 From: Vinoth Kannan Date: Fri, 6 Dec 2019 04:07:47 +0530 Subject: [PATCH] UX: remove the double-encoding of user titles. `{{}}` in handlebars are already escaping the HTML elements. --- .../javascripts/discourse/components/about-page-users.js.es6 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/components/about-page-users.js.es6 b/app/assets/javascripts/discourse/components/about-page-users.js.es6 index 59db7aee75b..fb9076cb303 100644 --- a/app/assets/javascripts/discourse/components/about-page-users.js.es6 +++ b/app/assets/javascripts/discourse/components/about-page-users.js.es6 @@ -1,6 +1,6 @@ import Component from "@ember/component"; import { userPath } from "discourse/lib/url"; -import { formatUsername, escapeExpression } from "discourse/lib/utilities"; +import { formatUsername } from "discourse/lib/utilities"; import { normalize } from "discourse/components/user-info"; import { renderAvatar } from "discourse/helpers/user-avatar"; import { computed } from "@ember/object"; @@ -18,7 +18,7 @@ export default Component.extend({ name, userPath: userPath(user.username), avatar: renderAvatar(user, { imageSize: "large" }), - title: escapeExpression(user.title || ""), + title: user.title || "", formatedUsername: formatUsername(user.username) }; });