REFACTOR: Rename SiteSetting.disable_edit_notifications to disable_system_edit_notifications (#7958)

* REFACTOR: Rename SiteSetting.disable_edit_notifications to disable_system_edit_notifications

- The older name could cause some confusion because the setting does not disable all edit notifications, only system ones.

* FIX: Add frozen_string_literal: true in the migration

* DEV: Deprecate 'disable_edit_notifications'

lib/site_settings/deprecated_settings.rb

@@ -15,7 +15,8 @@ module SiteSettings::DeprecatedSettings
     ['twitter_summary_large_image_url', 'twitter_summary_large_image', false, '2.3'],
     ['push_notifications_icon_url', 'push_notifications_icon', false, '2.3'],
     ['show_email_on_profile', 'moderators_view_emails', true, '2.4'],
-    ['allow_moderators_to_create_categories', 'moderators_create_categories', true, '2.4']
+    ['allow_moderators_to_create_categories', 'moderators_create_categories', true, '2.4'],
+    ['disable_edit_notifications', 'disable_system_edit_notifications', true, '2.4']
   ]
 
   def setup_deprecated_methods

lib/tasks/posts.rake

@@ -97,8 +97,8 @@ def rebake_posts(opts = {})
   puts "Rebaking post markdown for '#{RailsMultisite::ConnectionManagement.current_db}'"
 
   begin
-    disable_edit_notifications = SiteSetting.disable_edit_notifications
-    SiteSetting.disable_edit_notifications = true
+    disable_system_edit_notifications = SiteSetting.disable_system_edit_notifications
+    SiteSetting.disable_system_edit_notifications = true
 
     total = Post.count
     rebaked = 0
@@ -112,7 +112,7 @@ def rebake_posts(opts = {})
       end
     end
   ensure
-    SiteSetting.disable_edit_notifications = disable_edit_notifications
+    SiteSetting.disable_system_edit_notifications = disable_system_edit_notifications
   end
 
   puts "", "#{rebaked} posts done!", "-" * 50