From dce518477ce6b4f2b1b457108a9b19100d22dfd1 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Mon, 21 Sep 2020 10:27:08 +1000 Subject: [PATCH] FIX: if no group is found, raise correct error Previously missing group could lead to an error cause can_see_group_messages expects a group. --- app/controllers/list_controller.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/controllers/list_controller.rb b/app/controllers/list_controller.rb index bd662ab1592..24797d6b8f2 100644 --- a/app/controllers/list_controller.rb +++ b/app/controllers/list_controller.rb @@ -154,6 +154,7 @@ class ListController < ApplicationController when :private_messages_group, :private_messages_group_archive define_method("#{action}") do group = Group.find_by(name: params[:group_name]) + raise Discourse::NotFound if !group raise Discourse::NotFound unless guardian.can_see_group_messages?(group) message_route(action)