IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Adjust reviewable menu placement on mobile (#11420)

Browse Source 
Shows the actions dropdown above the triggering button to avoid some
options from displaying below mobile navigation in DiscourseHub.
This commit is contained in:
Penar Musaraj 2020-12-07 13:39:18 -05:00 committed by GitHub
parent 62cf30bec1
commit dd9ec827e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/discourse/app/components/reviewable-bundled-action.js
View File

@ -1,11 +1,21 @@
import { alias, gt } from "@ember/object/computed"; import { alias, gt } from "@ember/object/computed";
import Component from "@ember/component"; import Component from "@ember/component";
import discourseComputed from "discourse-common/utils/decorators";
import { isRTL } from "discourse/lib/text-direction";
export default Component.extend({ export default Component.extend({
tagName: "", tagName: "",
multiple: gt("bundle.actions.length", 1), multiple: gt("bundle.actions.length", 1),
first: alias("bundle.actions.firstObject"), first: alias("bundle.actions.firstObject"),
@discourseComputed()
placement() {
const vertical = this.site.mobileView ? "top" : "bottom",
horizontal = isRTL() ? "end" : "start";
return `${vertical}-${horizontal}`;
},
actions: { actions: {
performById(id) { performById(id) {
this.attrs.performAction(this.get("bundle.actions").findBy("id", id)); this.attrs.performAction(this.get("bundle.actions").findBy("id", id));

1
app/assets/javascripts/discourse/app/templates/components/reviewable-bundled-action.hbs
View File

@ -8,6 +8,7 @@
options=(hash options=(hash
icon=bundle.icon icon=bundle.icon
disabled=reviewableUpdating disabled=reviewableUpdating
placement=placement
) )
}} }}
{{else}} {{else}}