From ddf7bbfa97384873e76ffa7ef0a3e62ab7a9cb3f Mon Sep 17 00:00:00 2001
From: Jan Cernik <66427541+jancernik@users.noreply.github.com>
Date: Tue, 30 Apr 2024 12:31:39 -0500
Subject: [PATCH] FIX: Do not show empty list in the topic admin menu (#26825)

---
 .../app/components/topic-admin-menu.gjs       | 57 ++++++++++---------
 1 file changed, 31 insertions(+), 26 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs b/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
index 2546907524f..d6321738cde 100644
--- a/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
@@ -294,33 +294,38 @@ export default class TopicAdminMenu extends Component {
                     {{/if}}
                   </ul>
 
-                  <ul class="topic-admin-menu-undefined">
-                    {{#if this.currentUser.staff}}
-                      <li class="topic-admin-moderation-history">
-                        <DButton
-                          class="btn-transparent"
-                          @label="review.moderation_history"
-                          @href={{this.topicModerationHistoryUrl}}
-                          @icon="list"
-                        />
-                      </li>
-                    {{/if}}
+                  {{#if (or this.currentUser.staff this.extraButtons.length)}}
+                    <ul class="topic-admin-menu-undefined">
+                      {{#if this.currentUser.staff}}
+                        <li class="topic-admin-moderation-history">
+                          <DButton
+                            class="btn-transparent"
+                            @label="review.moderation_history"
+                            @href={{this.topicModerationHistoryUrl}}
+                            @icon="list"
+                          />
+                        </li>
+                      {{/if}}
 
-                    {{#each this.extraButtons as |button|}}
-                      <li>
-                        <DButton
-                          @label={{button.label}}
-                          @translatedLabel={{button.translatedLabel}}
-                          @icon={{button.icon}}
-                          class={{concatClass
-                            "btn-transparent"
-                            button.className
-                          }}
-                          @action={{fn this.onExtraButtonAction button.action}}
-                        />
-                      </li>
-                    {{/each}}
-                  </ul>
+                      {{#each this.extraButtons as |button|}}
+                        <li>
+                          <DButton
+                            @label={{button.label}}
+                            @translatedLabel={{button.translatedLabel}}
+                            @icon={{button.icon}}
+                            class={{concatClass
+                              "btn-transparent"
+                              button.className
+                            }}
+                            @action={{fn
+                              this.onExtraButtonAction
+                              button.action
+                            }}
+                          />
+                        </li>
+                      {{/each}}
+                    </ul>
+                  {{/if}}
                 </ul>
               </div>
             </:content>