IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Build correct topic list filter (#11473)

Browse Source 
* FIX: 'false' value was treated as a truthy value

For example, latest.json?no_subcategories=false used to have set
no_subcategories to the string value of 'false', which is not false.

* DEV: Remove dead code

* FIX: Redirect to /none under the right conditions

These conditions are:
 - neither /all or /none present
 - only for default filter

* FIX: Build correct topic list filter

/none was never added to the topic list filter

* FIX: Do not show count for subcategories if 'none' category

* FIX: preload_key must contain /none if no_subcategories
This commit is contained in:
Bianca Nenciu
2020-12-11 14:20:48 +02:00
committed by GitHub
parent 36b4712349
commit df26d2e72a
7 changed files with 61 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/topic_query_params.rb
View File

@@ -16,9 +16,7 @@ module TopicQueryParams
# hacky columns get special handling
options[:topic_ids] = param_to_integer_list(:topic_ids)
if options[:no_subcategories] == 'true'
options[:no_subcategories] = true
end
options[:no_subcategories] = options[:no_subcategories] == 'true' if options[:no_subcategories].present?
options
end