IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 18:30:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: prefer using ordering in relation over default scope

Browse Source
This commit is contained in:
Sam 2018-05-29 09:34:12 +10:00
parent 16d0ab5654
commit df815d6c0e
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/post.rb
View File

@ -48,7 +48,7 @@ class Post < ActiveRecord::Base
has_many :post_details
has_many :post_revisions
has_many :revisions, foreign_key: :post_id, class_name: 'PostRevision'
has_many :revisions, -> { order(:number) }, foreign_key: :post_id, class_name: 'PostRevision'
has_many :user_actions, foreign_key: :target_post_id

2
app/models/post_revision.rb
View File

@ -4,8 +4,6 @@ class PostRevision < ActiveRecord::Base
belongs_to :post
belongs_to :user
default_scope { order('number ASC') }
serialize :modifications, Hash
after_create :create_notification

7
spec/models/post_spec.rb
View File

@ -1095,4 +1095,11 @@ describe Post do
expect(hidden_topic.visible).to eq(false)
end
it "automatically orders post revisions by number ascending" do
post = Fabricate(:post)
post.revisions.create!(user_id: 1, post_id: post.id, number: 2)
post.revisions.create!(user_id: 1, post_id: post.id, number: 1)
expect(post.revisions.pluck(:number)).to eq([1, 2])
end
end