From e0aec238443d95fa387e62d46ca674e7bb10a744 Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Sun, 26 Apr 2020 22:18:44 +0200
Subject: [PATCH] DEV: Don't warn about valid data

---
 app/jobs/onceoff/migrate_url_site_settings.rb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/app/jobs/onceoff/migrate_url_site_settings.rb b/app/jobs/onceoff/migrate_url_site_settings.rb
index 89ca6e67b75..7f0bb37d1e8 100644
--- a/app/jobs/onceoff/migrate_url_site_settings.rb
+++ b/app/jobs/onceoff/migrate_url_site_settings.rb
@@ -17,11 +17,9 @@ module Jobs
 
     def execute_onceoff(args)
       SETTINGS.each do |old_setting, new_setting|
+        upload = SiteSetting.get(new_setting)
 
-        if (upload = SiteSetting.get(new_setting)) && upload.id >= Upload::SEEDED_ID_THRESHOLD
-          logger.warn("Skipping migration of the Site Setting #{new_setting} to url cause upload #{upload} already exists for it")
-          next
-        end
+        next if upload && upload.id >= Upload::SEEDED_ID_THRESHOLD
 
         old_url = DB.query_single(
           "SELECT value FROM site_settings WHERE name = '#{old_setting}'"