FIX: improvements for the admin sidebar (#26168)

- add all settings link
- hide the customize header menu when the admin sidebar

app/assets/javascripts/admin/addon/templates/customize.hbs

@@ -1,64 +1,66 @@
-<AdminNav>
+{{#unless this.currentUser.use_admin_sidebar}}
-  {{#if this.currentUser.admin}}
+  <AdminNav>
-    <NavItem
+    {{#if this.currentUser.admin}}
-      @route="adminCustomizeThemes"
-      @label="admin.customize.theme.title"
-      class="admin-customize-themes"
-    />
-    <NavItem
-      @route="adminCustomize.colors"
-      @label="admin.customize.colors.title"
-      class="admin-customize-colors"
-    />
-    <NavItem
-      @route="adminSiteText"
-      @label="admin.site_text.title"
-      class="admin-customize-site-text"
-    />
-    <NavItem
-      @route="adminCustomizeEmailTemplates"
-      @label="admin.customize.email_templates.title"
-      class="admin-customize-email-templates"
-    />
-    <NavItem
-      @route="adminCustomizeEmailStyle"
-      @label="admin.customize.email_style.title"
-      class="admin-customize-email-styles"
-    />
-    <NavItem
-      @route="adminUserFields"
-      @label="admin.user_fields.title"
-      class="admin-customize-user-fields"
-    />
-    <NavItem
-      @route="adminEmojis"
-      @label="admin.emoji.title"
-      class="admin-customize-emojis"
-    />
-    <NavItem
-      @route="adminPermalinks"
-      @label="admin.permalink.title"
-      class="admin-customize-permalinks"
-    />
-    <NavItem
-      @route="adminEmbedding"
-      @label="admin.embedding.title"
-      class="admin-customize-embedding"
-    />
-    {{#if this.siteSettings.experimental_form_templates}}
       <NavItem
-        @route="adminCustomizeFormTemplates"
+        @route="adminCustomizeThemes"
-        @label="admin.form_templates.nav_title"
+        @label="admin.customize.theme.title"
-        class="admin-customize-form-templates"
+        class="admin-customize-themes"
       />
+      <NavItem
+        @route="adminCustomize.colors"
+        @label="admin.customize.colors.title"
+        class="admin-customize-colors"
+      />
+      <NavItem
+        @route="adminSiteText"
+        @label="admin.site_text.title"
+        class="admin-customize-site-text"
+      />
+      <NavItem
+        @route="adminCustomizeEmailTemplates"
+        @label="admin.customize.email_templates.title"
+        class="admin-customize-email-templates"
+      />
+      <NavItem
+        @route="adminCustomizeEmailStyle"
+        @label="admin.customize.email_style.title"
+        class="admin-customize-email-styles"
+      />
+      <NavItem
+        @route="adminUserFields"
+        @label="admin.user_fields.title"
+        class="admin-customize-user-fields"
+      />
+      <NavItem
+        @route="adminEmojis"
+        @label="admin.emoji.title"
+        class="admin-customize-emojis"
+      />
+      <NavItem
+        @route="adminPermalinks"
+        @label="admin.permalink.title"
+        class="admin-customize-permalinks"
+      />
+      <NavItem
+        @route="adminEmbedding"
+        @label="admin.embedding.title"
+        class="admin-customize-embedding"
+      />
+      {{#if this.siteSettings.experimental_form_templates}}
+        <NavItem
+          @route="adminCustomizeFormTemplates"
+          @label="admin.form_templates.nav_title"
+          class="admin-customize-form-templates"
+        />
+      {{/if}}
     {{/if}}
-  {{/if}}
+    <NavItem
-  <NavItem
+      @route="adminWatchedWords"
-    @route="adminWatchedWords"
+      @label="admin.watched_words.title"
-    @label="admin.watched_words.title"
+      class="admin-customize-watched-words"
-    class="admin-customize-watched-words"
+    />
-  />
+  </AdminNav>
-</AdminNav>
+{{/unless}}
 
 <div class="admin-container">
   {{outlet}}

app/assets/javascripts/discourse/app/lib/sidebar/admin-nav-map.js

@@ -378,6 +378,12 @@ export const ADMIN_NAV_MAP = [
         label: "admin.advanced.sidebar_link.experimental",
         icon: "discourse-sparkles",
       },
+      {
+        name: "admin_all_site_settings",
+        route: "adminSiteSettings",
+        label: "admin.advanced.sidebar_link.all_site_settings",
+        icon: "cog",
+      },
     ],
   },
 ];

config/locales/client.en.yml

@@ -5328,6 +5328,7 @@ en:
           other_options: "Other"
           search: "Search"
           experimental: "Experimental"
+          all_site_settings: "All Site Settings"
 
       navigation_menu:
         sidebar: "Sidebar"