IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 18:30:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Ensure legacy browser handling uses full <noscript> content

Browse Source 
If the noscript tag contains a lot of data, browsers seem to split it across multiple `text` nodes, so we need to concatenate them.
This commit is contained in:
David Taylor 2022-04-07 15:08:11 +01:00
parent e9c1e3d022
commit e16f8a5ee6
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/browser-update.js
View File

@ -29,11 +29,16 @@
// find the element with the "data-path" attribute set
for (var i = 0; i < noscriptElements.length; ++i) {
if (noscriptElements[i].getAttribute("data-path")) {
// noscriptElements[i].innerHTML contains encoded HTML
if (noscriptElements[i].childNodes.length > 0) {
mainElement.innerHTML = noscriptElements[i].childNodes[0].nodeValue;
break;
// noscriptElements[i].innerHTML contains encoded HTML, so we need to access
// the childNodes instead. Browsers seem to split very long content into multiple
// text childNodes.
var result = "";
for (var j = 0; j < noscriptElements[i].childNodes.length; j++) {
result += noscriptElements[i].childNodes[j].nodeValue;
}
mainElement.innerHTML = result;
break;
}
}