IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Review Queue Query parameters were not refreshing in Ember CLI builds (#13101)

Browse Source 
The problem was we were setting the properties then immediately calling
`refreshRoute` which was being executed before the properties were
settled via the runloop.
This commit is contained in:
Robin Ward 2021-05-20 14:00:25 -04:00 committed by GitHub
parent e2f9da9795
commit e1b99d3cad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/javascripts/discourse/app/controllers/review-index.js
View File

@ -2,6 +2,7 @@ import Controller from "@ember/controller";
import I18n from "I18n"; import I18n from "I18n";
import discourseComputed from "discourse-common/utils/decorators"; import discourseComputed from "discourse-common/utils/decorators";
import { isPresent } from "@ember/utils"; import { isPresent } from "@ember/utils";
import { next } from "@ember/runloop";
export default Controller.extend({ export default Controller.extend({
queryParams: [ queryParams: [
@ -93,6 +94,10 @@ export default Controller.extend({
this.setProperties(range); this.setProperties(range);
}, },
refreshModel() {
next(() => this.send("refreshRoute"));
},
actions: { actions: {
remove(ids) { remove(ids) {
if (!ids) { if (!ids) {
@ -104,7 +109,7 @@ export default Controller.extend({
}); });
if (newList.length === 0) { if (newList.length === 0) {
this.send("refreshRoute"); this.refreshModel();
} else { } else {
this.set("reviewables", newList); this.set("reviewables", newList);
} }
@ -112,7 +117,7 @@ export default Controller.extend({
resetTopic() { resetTopic() {
this.set("topic_id", null); this.set("topic_id", null);
this.send("refreshRoute"); this.refreshModel();
}, },
refresh() { refresh() {
@ -165,7 +170,7 @@ export default Controller.extend({
additional_filters: JSON.stringify(this.additionalFilters), additional_filters: JSON.stringify(this.additionalFilters),
}); });
this.send("refreshRoute"); this.refreshModel();
}, },
loadMore() { loadMore() {