IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-16 18:24:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: use * when apply italics in the editor instead of _ (#7063)

Browse Source
This commit is contained in:
Erick Guan 2019-02-27 10:36:14 +01:00 committed by Régis Hanol
parent 326d892f5e
commit e1d1073273
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/components/d-editor.js.es6
View File

@ -80,7 +80,7 @@ class Toolbar {
icon: "italic",
label: getButtonLabel("composer.italic_label", "I"),
shortcut: "I",
perform: e => e.applySurround("_", "_", "italic_text")
perform: e => e.applySurround("*", "*", "italic_text")
});
if (opts.showLink) {

6
test/javascripts/components/d-editor-test.js.es6
View File

@ -157,7 +157,7 @@ testCase(`bold with a multiline selection`, async function(assert, textarea) {
testCase(`italic button with no selection`, async function(assert, textarea) {
await click(`button.italic`);
const example = I18n.t(`composer.italic_text`);
assert.equal(this.get("value"), `hello world._${example}_`);
assert.equal(this.get("value"), `hello world.*${example}*`);
assert.equal(textarea.selectionStart, 13);
assert.equal(textarea.selectionEnd, 13 + example.length);
@ -168,7 +168,7 @@ testCase(`italic button with a selection`, async function(assert, textarea) {
textarea.selectionEnd = 11;
await click(`button.italic`);
assert.equal(this.get("value"), `hello _world_.`);
assert.equal(this.get("value"), `hello *world*.`);
assert.equal(textarea.selectionStart, 7);
assert.equal(textarea.selectionEnd, 12);
@ -185,7 +185,7 @@ testCase(`italic with a multiline selection`, async function(assert, textarea) {
textarea.selectionEnd = 12;
await click(`button.italic`);
assert.equal(this.get("value"), `_hello_\n\n_world_\n\ntest.`);
assert.equal(this.get("value"), `*hello*\n\n*world*\n\ntest.`);
assert.equal(textarea.selectionStart, 0);
assert.equal(textarea.selectionEnd, 16);