IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Broken computing of userHasTimezone in bookmark modal and missing tap-tile templates for regular users (#9229)

Browse Source 
Based on reports here https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542

* Because the `userHasTimezone` property was computed and we were checking on an (essentially) global object, ember was not aware that the user timezone had changed because it changed in a different place. instead set the timezone as internal state for the modal on show and base the computed property off of that so it mutates correctly
* The tap-tile components were in the admin folder completely unnecessarily, move them out into the main discourse folder otherwise noone else can use the new bookmarks (icon + text is missing)
This commit is contained in:
Martin Brennan
2020-03-18 11:12:23 +10:00
committed by GitHub
parent 45ce9876cc
commit e2ce12d414
4 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/admin/templates/components/tap-tile-grid.hbs
View File

@@ -1 +0,0 @@
{{ yield (hash activeTile=this.activeTile) }}

2
app/assets/javascripts/admin/templates/components/tap-tile.hbs
View File

@@ -1,2 +0,0 @@
{{d-icon icon}}
{{text}}