IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: allow re-scoping chat user search via a plugin (#26361)

Browse Source 
This enables the following in Discourse AI

```
 plugin.register_modifier(:chat_allowed_bot_user_ids) do |user_ids, guardian|
  if guardian.user
    mentionables = AiPersona.mentionables(user: guardian.user)
    allowed_bot_ids = mentionables.map { |mentionable| mentionable[:user_id] }
    user_ids.concat(allowed_bot_ids)
  end
  user_ids
end
```

some bots that are id < 0 need to be discoverable in search otherwise people can not talk to them.

---------

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
This commit is contained in:
Sam
2024-03-27 08:55:53 +11:00
committed by GitHub
parent 680f1ff19c
commit e3a0faefc5
4 changed files with 50 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/chat/app/services/chat/search_chatable.rb
View File

@@ -98,11 +98,17 @@ module Chat
user_search = ::UserSearch.new(context.term, limit: 10)
if context.term.blank?
user_search = user_search.scoped_users.real.includes(:user_option)
user_search = user_search.scoped_users
else
user_search = user_search.search.real.includes(:user_option)
user_search = user_search.search
end
allowed_bot_user_ids =
DiscoursePluginRegistry.apply_modifier(:chat_allowed_bot_user_ids, [], guardian)
user_search = user_search.real(allowed_bot_user_ids: allowed_bot_user_ids)
user_search = user_search.includes(:user_option)
if context.excluded_memberships_channel_id
user_search =
user_search.where(

21
plugins/chat/spec/services/chat/search_chatable_spec.rb
View File

@@ -82,6 +82,27 @@ RSpec.describe Chat::SearchChatable do
expect(result.users).to_not include(current_user)
end
context "when chat_allowed_bot_user_ids modifier exists" do
fab!(:bot_1) { Fabricate(:user, id: -500) }
fab!(:bot_2) { Fabricate(:user, id: -501) }
it "alters the users returned" do
modifier_block = Proc.new { [bot_2.id] }
plugin_instance = Plugin::Instance.new
plugin_instance.register_modifier(:chat_allowed_bot_user_ids, &modifier_block)
expect(result.users).to_not include(bot_1)
expect(result.users).to include(bot_2)
expect(result.users).to include(current_user, sam, charlie, alain)
ensure
DiscoursePluginRegistry.unregister_modifier(
plugin_instance,
:chat_allowed_bot_user_ids,
&modifier_block
)
end
end
end
context "when not including users" do