IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5715 from jjaffeux/remove-title-user-notifications

Browse Source 
FIX: remove unneeded and uninformative title on user notifications list
This commit is contained in:
Robin Ward
2018-03-29 09:23:09 -04:00
committed by GitHub
parent 99cf091774 466f09bbc4
commit e4a5b0c39a
40 changed files with 2 additions and 514 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/widgets/notification-item.js.es6
View File

@@ -101,10 +101,8 @@ createWidget('notification-item', {
let { data } = attrs;
let infoKey = notName === 'custom' ? data.message : notName;
let title = I18n.t(`notifications.alt.${infoKey}`);
let icon = iconNode(`notification.${infoKey}`, { title });
let text = emojiUnescape(this.text(notificationType, notName));
let icon = iconNode(`notification.${infoKey}`);
// We can use a `<p>` tag here once other languages have fixed their HTML
// translations.
@@ -113,7 +111,7 @@ createWidget('notification-item', {
let contents = [ icon, html ];
const href = this.url();
return href ? h('a', { attributes: { href, title, 'data-auto-route': true } }, contents) : contents;
return href ? h('a', { attributes: { href, 'data-auto-route': true } }, contents) : contents;
},
click(e) {