FIX: Yet more linting fixes

app/assets/javascripts/admin/components/resumable-upload.js.es6

@@ -52,9 +52,7 @@ export default Component.extend(
 
       this.resumable.on("fileProgress", file => {
         // update progress
-        later(() =>
+        later(() => this.set("progress", parseInt(file.progress() * 100, 10)));
-          this.set("progress", parseInt(file.progress() * 100, 10))
-        );
       });
 
       this.resumable.on("fileSuccess", file => {

app/assets/javascripts/discourse/components/choose-message.js.es6

@@ -58,9 +58,7 @@ export default Component.extend({
     chooseMessage(message) {
       const messageId = Ember.get(message, "id");
       this.set("selectedTopicId", messageId);
-      next(() =>
+      next(() => $(`#choose-message-${messageId}`).prop("checked", "true"));
-        $(`#choose-message-${messageId}`).prop("checked", "true")
-      );
       return false;
     }
   }

app/assets/javascripts/discourse/components/composer-editor.js.es6

@@ -197,13 +197,7 @@ export default Component.extend({
       this._initInputPreviewSync($input, $preview);
     } else {
       $input.on("scroll", () =>
-        throttle(
+        throttle(this, this._syncEditorAndPreviewScroll, $input, $preview, 20)
-          this,
-          this._syncEditorAndPreviewScroll,
-          $input,
-          $preview,
-          20
-        )
       );
     }
 

app/assets/javascripts/discourse/components/d-editor.js.es6

@@ -444,10 +444,7 @@ export default Component.extend({
             if (filterInput) {
               filterInput.value = v.term;
 
-              later(
+              later(() => filterInput.dispatchEvent(new Event("input")), 50);
-                () => filterInput.dispatchEvent(new Event("input")),
-                50
-              );
             }
           });
 

app/assets/javascripts/discourse/components/discovery-topics-list.js.es6

@@ -14,9 +14,7 @@ const DiscoveryTopicsListComponent = Component.extend(UrlRefresh, LoadMore, {
   _readjustScrollPosition() {
     const scrollTo = this.session.get("topicListScrollPosition");
     if (scrollTo && scrollTo >= 0) {
-      schedule("afterRender", () =>
+      schedule("afterRender", () => $(window).scrollTop(scrollTo + 1));
-        $(window).scrollTop(scrollTo + 1)
-      );
     } else {
       scheduleOnce("afterRender", this, this.loadMoreUnlessFull);
     }

app/assets/javascripts/discourse/components/global-notice.js.es6

@@ -92,10 +92,7 @@ export default Component.extend(
       this._boundRerenderBuffer = bind(this, this.rerenderBuffer);
       LogsNotice.current().addObserver("hidden", this._boundRerenderBuffer);
 
-      this._boundResetCurrentProp = bind(
+      this._boundResetCurrentProp = bind(this, this._resetCurrentProp);
-        this,
-        this._resetCurrentProp
-      );
       $(this.element).on(
         "click.global-notice",
         ".alert-logs-notice .close",

app/assets/javascripts/discourse/components/pwa-install-banner.js.es6

@@ -19,10 +19,7 @@ export default Component.extend({
 
   @on("didInsertElement")
   _registerListener() {
-    this._promptEventHandler = bind(
+    this._promptEventHandler = bind(this, this._handleInstallPromptEvent);
-      this,
-      this._handleInstallPromptEvent
-    );
     window.addEventListener("beforeinstallprompt", this._promptEventHandler);
   },
 

app/assets/javascripts/discourse/components/scrolling-post-stream.js.es6

@@ -314,8 +314,7 @@ export default MountWidget.extend({
 
   didInsertElement() {
     this._super(...arguments);
-    const debouncedScroll = () =>
+    const debouncedScroll = () => debounce(this, this._scrollTriggered, 10);
-      debounce(this, this._scrollTriggered, 10);
 
     this._previouslyNearby = {};
 

app/assets/javascripts/discourse/components/signup-cta.js.es6

@@ -11,10 +11,7 @@ export default Component.extend({
     hideForSession() {
       this.session.set("hideSignupCta", true);
       this.keyValueStore.setItem("anon-cta-hidden", new Date().getTime());
-      later(
+      later(() => this.session.set("showSignupCta", false), 20 * 1000);
-        () => this.session.set("showSignupCta", false),
-        20 * 1000
-      );
     }
   },
 

app/assets/javascripts/discourse/components/topic-list.js.es6

@@ -70,9 +70,7 @@ export default Component.extend(LoadMore, {
 
     let scrollTo = this.session.get("topicListScrollPosition");
     if (scrollTo && scrollTo >= 0) {
-      schedule("afterRender", () =>
+      schedule("afterRender", () => $(window).scrollTop(scrollTo + 1));
-        $(window).scrollTop(scrollTo + 1)
-      );
     }
   },
 

app/assets/javascripts/discourse/components/topic-progress.js.es6

@@ -101,12 +101,7 @@ export default Component.extend({
 
     const prevEvent = this.prevEvent;
     if (prevEvent) {
-      scheduleOnce(
+      scheduleOnce("afterRender", this, this._topicScrolled, prevEvent);
-        "afterRender",
-        this,
-        this._topicScrolled,
-        prevEvent
-      );
     } else {
       scheduleOnce("afterRender", this, this._updateProgressBar);
     }

app/assets/javascripts/discourse/components/topic-timer-info.js.es6

@@ -87,11 +87,7 @@ export default Component.extend(
 
         // TODO Sam: concerned this can cause a heavy rerender loop
         if (!Ember.testing) {
-          this._delayedRerender = later(
+          this._delayedRerender = later(this, this.rerender, rerenderDelay);
-            this,
-            this.rerender,
-            rerenderDelay
-          );
         }
       }
     },

app/assets/javascripts/discourse/lib/safari-hacks.js.es6

@@ -95,10 +95,7 @@ function positioningWorkaround($fixedElement) {
 
       if (!iOSWithVisualViewport()) {
         fixedElement.style.height = oldHeight;
-        later(
+        later(() => $(fixedElement).removeClass("no-transition"), 500);
-          () => $(fixedElement).removeClass("no-transition"),
-          500
-        );
       }
 
       $(window).scrollTop(originalScrollTop);

app/assets/javascripts/discourse/routes/discovery-categories.js.es6

@@ -135,9 +135,7 @@ const DiscoveryCategoriesRoute = DiscourseRoute.extend(OpenComposer, {
     },
 
     didTransition() {
-      next(() =>
+      next(() => this.controllerFor("application").set("showFooter", true));
-        this.controllerFor("application").set("showFooter", true)
-      );
       return true;
     }
   }