FIX: Add attachment content-disposition for all non-image files (#10058)

Browse Source

This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.

See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.

...

This commit is contained in:

Martin Brennan

2020-06-17 11:16:37 +10:00

committed by GitHub

parent dcb816b548

commit e5da2d24e5

4 changed files with 60 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

spec/fixtures/media/small.mp3 vendored Normal file

Binary file not shown.

BIN

spec/fixtures/media/small.mp4 vendored Normal file

Binary file not shown.