From e5fbdde56f3fa6b10384d814662ae515acfb70f5 Mon Sep 17 00:00:00 2001 From: Sam Date: Sun, 13 Oct 2013 08:07:09 +1100 Subject: [PATCH] filter params correctly from error log --- app/models/error_log.rb | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/app/models/error_log.rb b/app/models/error_log.rb index 6acb8400fc5..097dbce8ddd 100644 --- a/app/models/error_log.rb +++ b/app/models/error_log.rb @@ -29,7 +29,7 @@ class ErrorLog date: DateTime.now, guid: SecureRandom.uuid, user_id: user && user.id, - request: filter_sensitive_post_data_parameters(controller, request.parameters).inspect, + parameters: request && request.filtered_parameters.to_json, action: controller.action_name, controller: controller.controller_name, backtrace: sanitize_backtrace(exception.backtrace).join("\n"), @@ -92,17 +92,4 @@ class ErrorLog trace.map { |line| Pathname.new(line.gsub(re, "[RAILS_ROOT]")).cleanpath.to_s } end - def self.exclude_raw_post_parameters?(controller) - controller && controller.respond_to?(:filter_parameters) - end - - def self.filter_sensitive_post_data_parameters(controller, parameters) - exclude_raw_post_parameters?(controller) ? controller.__send__(:filter_parameters, parameters) : parameters - end - - def self.filter_sensitive_post_data_from_env(env_key, env_value, controller) - return env_value unless exclude_raw_post_parameters? - return PARAM_FILTER_REPLACEMENT if (env_key =~ /RAW_POST_DATA/i) - return controller.__send__(:filter_parameters, {env_key => env_value}).values[0] - end end