IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 02:40:53 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Users can't request to join group due to alias level restriction.

Browse Source 
https://meta.discourse.org/t/request-to-join-group-not-working/62371
This commit is contained in:
Guo Xiang Tan 2017-05-12 09:25:38 +08:00
parent 55b61e9bea
commit e63614024d
3 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/components/group-membership-button.js.es6
View File

@ -8,11 +8,6 @@ export default Ember.Component.extend({
return publicGroup;
},
@computed('model.allow_membership_requests', 'model.alias_level')
canRequestMembership(allowMembershipRequests, aliasLevel) {
return allowMembershipRequests && aliasLevel === 99;
},
@computed("model.is_group_user", "model.id", "groupUserIds")
userIsGroupUser(isGroupUser, groupId, groupUserIds) {
if (isGroupUser !== undefined) {

2
app/assets/javascripts/discourse/templates/components/group-membership-button.hbs
View File

@ -12,7 +12,7 @@
label="groups.join"
disabled=updatingMembership}}
{{/if}}
{{else if canRequestMembership}}
{{else if model.allow_membership_requests}}
{{#if userIsGroupUser}}
{{#if showMembershipStatus}}
{{d-button

18
test/javascripts/components/group-membership-button-test.js.es6
View File

@ -18,24 +18,6 @@ test('canJoinGroup', function() {
equal(this.subject().get("canJoinGroup"), true, "can't join group when not logged in");
});
test('canRequestMembership', function() {
this.subject().setProperties({
model: { allow_membership_requests: false, alias_level: 0 }
});
equal(this.subject().get('canRequestMembership'), false);
this.subject().setProperties({
currentUser: currentUser(), model: { allow_membership_requests: true, alias_level: 99 }
});
equal(this.subject().get('canRequestMembership'), true);
this.subject().set("model.alias_level", 0);
equal(this.subject().get('canRequestMembership'), false);
});
test('userIsGroupUser', function() {
this.subject().setProperties({
model: { is_group_user: true }