IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do not call preventDefault on right and middle-click/Ctrl+click.

Browse Source 
This should fix the middle click popup blocker issue on Firefox.
This commit is contained in:
Vikhyat Korrapati
2014-03-13 11:03:19 +05:30
parent 9eb3958374
commit e798705aec
2 changed files with 36 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
app/assets/javascripts/discourse/lib/click_track.js
View File

@@ -17,21 +17,7 @@ Discourse.ClickTrack = {
var $link = $(e.currentTarget);
if ($link.hasClass('lightbox')) return true;
e.preventDefault();
// We don't track clicks on quote back buttons
if ($link.hasClass('back') || $link.hasClass('quote-other-topic')) return true;
// Remove the href, put it as a data attribute
if (!$link.data('href')) {
$link.addClass('no-href');
$link.data('href', $link.attr('href'));
$link.attr('href', null);
// Don't route to this URL
$link.data('auto-route', true);
}
var href = $link.data('href'),
var href = $link.attr('href') || $link.data('href'),
$article = $link.closest('article'),
postId = $article.data('post-id'),
topicId = $('#topic').data('topic-id'),
@@ -83,8 +69,21 @@ Discourse.ClickTrack = {
},
dataType: 'html'
});
window.open(href, '_blank');
return false;
return true;
}
e.preventDefault();
// We don't track clicks on quote back buttons
if ($link.hasClass('back') || $link.hasClass('quote-other-topic')) return true;
// Remove the href, put it as a data attribute
if (!$link.data('href')) {
$link.addClass('no-href');
$link.data('href', $link.attr('href'));
$link.attr('href', null);
// Don't route to this URL
$link.data('auto-route', true);
}
// If we're on the same site, use the router and track via AJAX