From e7bd288d7b1019c6986a7eac7d8f9cb9505cb0bb Mon Sep 17 00:00:00 2001 From: Jeff Wong Date: Fri, 6 Dec 2019 16:42:15 -0800 Subject: [PATCH] FIX: Skip validation on enforcing second factor change if the value is "no" Without this, this site setting breaks plugin tests if local logins are disabled in the plugin. --- lib/site_settings/validations.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/site_settings/validations.rb b/lib/site_settings/validations.rb index a24da43db58..56987b0dfed 100644 --- a/lib/site_settings/validations.rb +++ b/lib/site_settings/validations.rb @@ -151,6 +151,7 @@ module SiteSettings::Validations def validate_enforce_second_factor(new_val) return if SiteSetting.enable_local_logins + return if new_val == "no" validate_error :second_factor_cannot_be_enforced_with_disabled_local_login end