IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Replace User.unstage and User#unstage API with User#unstage! (#8906)

Browse Source 
* DEV: Replace User.unstage and User#unstage API with User#unstage!

Quoting @SamSaffron:

> User.unstage mixes concerns of both unstaging users and updating params which is fragile/surprising.
> u.unstage destroys notifications and raises a user_unstaged event prior to the user becoming unstaged and the user object being saved.

User#unstage! no longer updates user attributes and saves the object before triggering the `user_unstaged` event.

* Update one more spec

* Assign attributes after unstaging
This commit is contained in:
Jarek Radosz
2020-03-17 16:48:24 +01:00
committed by GitHub
parent 43b38dbbc2
commit e950471c0f
9 changed files with 41 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/discourse_single_sign_on.rb
View File

@@ -74,8 +74,7 @@ class DiscourseSingleSignOn < SingleSignOn
end
# ensure it's not staged anymore
user.unstage
user.save
user.unstage!
change_external_attributes_and_override(sso_record, user)