IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-08 12:08:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

A11Y: Add aria-labels to search inputs and search button (#11752)

Browse Source
This commit is contained in:
Kris
2021-01-19 14:32:32 -05:00
committed by GitHub
parent e6bbe9b5df
commit e968af6dd4
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/assets/javascripts/discourse/app/templates/components/google-search.hbs
+1 -1
View File
@@ -1,6 +1,6 @@
<div>
<form action="//google.com/search" id="google-search">
<input type="text" name="q" value={{searchTerm}}>
<input type="text" name="q" aria-label={{i18n "search.search_google"}} value={{searchTerm}}>
<input name="as_sitesearch" value={{siteUrl}} type="hidden">
<button class="btn btn-primary" type="submit">{{i18n "search.search_google_button"}}</button>
</form>
app/assets/javascripts/discourse/app/templates/full-page-search.hbs
+3 -3
View File
@@ -4,8 +4,8 @@
<div class="search-advanced">
{{#unless site.mobileView}}
<div class="search-bar">
{{search-text-field value=searchTerm class="full-page-search search no-blur search-query" enter=(action "search") hasAutofocus=hasAutofocus}}
{{d-button action=(action "search") icon="search" class="btn-primary search-cta" disabled=searchButtonDisabled}}
{{search-text-field value=searchTerm class="full-page-search search no-blur search-query" aria-label=(i18n "search.full_page_title") enter=(action "search") hasAutofocus=hasAutofocus}}
{{d-button action=(action "search") icon="search" class="btn-primary search-cta" ariaLabel="search.search_button" disabled=searchButtonDisabled}}
</div>
{{/unless}}
@@ -193,7 +193,7 @@
{{#if site.mobileView}}
<div class="search-bar">
{{search-text-field value=searchTerm class="full-page-search search no-blur search-query" enter=(action "search") hasAutofocus=hasAutofocus}}
{{d-button action=(action "search") icon="search" class="btn-primary search-cta" disabled=searchButtonDisabled}}
{{d-button action=(action "search") icon="search" class="btn-primary search-cta" ariaLabel="search.search_button" disabled=searchButtonDisabled}}
</div>
{{/if}}
app/assets/javascripts/discourse/app/widgets/search-menu-controls.js
+1
View File
@@ -23,6 +23,7 @@ createWidget("search-term", {
value: attrs.value || "",
autocomplete: "discourse",
placeholder: attrs.contextEnabled ? "" : I18n.t("search.title"),
"aria-label": I18n.t("search.title"),
};
},