IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Change default for push_notification_time_window_mins (#28431)

Browse Source 
Currently the push_notification_time_window_mins is set to 10
minutes by default. We want to change this to 1 minute, which is the
delay it has been set to on meta and our internal site already for over
a year now.

This conforms to the expectation users have that notifications are
delivered close to immediately.
This commit is contained in:
Martin Brennan 2024-08-20 15:46:07 +10:00 committed by GitHub
parent f41c4ccfc2
commit e9b427ff53
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/site_settings.yml
View File

@ -363,7 +363,7 @@ basic:
default: true default: true
client: true client: true
push_notification_time_window_mins: push_notification_time_window_mins:
default: 10 default: 1
min: 0 min: 0
short_title: short_title:
default: "" default: ""

1
spec/services/post_alerter_spec.rb
View File

@ -1360,6 +1360,7 @@ RSpec.describe PostAlerter do
end end
it "delays push notification for active online user" do it "delays push notification for active online user" do
SiteSetting.push_notification_time_window_mins = 10
evil_trout.update!(last_seen_at: 5.minutes.ago) evil_trout.update!(last_seen_at: 5.minutes.ago)
expect { mention_post }.to change { Jobs::PushNotification.jobs.count } expect { mention_post }.to change { Jobs::PushNotification.jobs.count }