From ea9ff108c5442d48f5fa3209da0492329f1bcf0f Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 3 Feb 2014 10:45:52 -0500 Subject: [PATCH] Move updating title count to the view, to ensure the topic list is visible when it happens. --- .../discourse/controllers/discovery_topics_controller.js | 4 ---- .../javascripts/discourse/views/discovery_topics_view.js | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/controllers/discovery_topics_controller.js b/app/assets/javascripts/discourse/controllers/discovery_topics_controller.js index ace88ad3c62..8eeb242def5 100644 --- a/app/assets/javascripts/discourse/controllers/discovery_topics_controller.js +++ b/app/assets/javascripts/discourse/controllers/discovery_topics_controller.js @@ -53,10 +53,6 @@ Discourse.DiscoveryTopicsController = Discourse.DiscoveryController.extend({ weekly: Em.computed.equal('period', 'weekly'), daily: Em.computed.equal('period', 'daily'), - updateTitle: function(){ - Discourse.notifyTitle(this.get('topicTrackingState.incomingCount')); - }.observes('topicTrackingState.incomingCount'), - footerMessage: function() { if (!this.get('allLoaded')) { return; } diff --git a/app/assets/javascripts/discourse/views/discovery_topics_view.js b/app/assets/javascripts/discourse/views/discovery_topics_view.js index 9a1cd641383..0256dbc499d 100644 --- a/app/assets/javascripts/discourse/views/discovery_topics_view.js +++ b/app/assets/javascripts/discourse/views/discovery_topics_view.js @@ -31,6 +31,10 @@ Discourse.DiscoveryTopicsView = Discourse.View.extend(Discourse.LoadMore, { } }, + _updateTitle: function() { + Discourse.notifyTitle(this.get('controller.topicTrackingState.incomingCount')); + }.observes('controller.topicTrackingState.incomingCount'), + // Remember where we were scrolled to saveScrollPosition: function() { Discourse.Session.current().set('topicListScrollPosition', $(window).scrollTop());