IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Disable upload instrumentation if performance.measure returns undefined (#14427)

Browse Source 
Firefox does not return a PerformanceMeasure object when using
performance.mark and performance.measure, even though MDN says it
should https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#return_value

So for now, we disable the upload instrumentation with a test
to see if a PerformanceMeasure (or anything really) is returned.
This commit is contained in:
Martin Brennan 2021-09-23 11:34:51 +10:00 committed by GitHub
parent 57f17854fb
commit ec087027b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/assets/javascripts/discourse/app/mixins/upload-debugging.js
View File

@ -1,4 +1,5 @@
import Mixin from "@ember/object/mixin"; import Mixin from "@ember/object/mixin";
import { warn } from "@ember/debug";
export default Mixin.create({ export default Mixin.create({
_consoleDebug(msg) { _consoleDebug(msg) {
@ -17,7 +18,27 @@ export default Mixin.create({
); );
}, },
_performanceApiSupport() {
performance.mark("testing support 1");
performance.mark("testing support 2");
const perfMeasure = performance.measure(
"performance api support",
"testing support 1",
"testing support 2"
);
return perfMeasure;
},
_instrumentUploadTimings() { _instrumentUploadTimings() {
if (!this._performanceApiSupport()) {
// TODO (martin) (2021-01-23) Check if FireFox fixed this yet.
warn(
"Some browsers do not return a PerformanceMeasure when calling performance.mark, disabling instrumentation. See https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#return_value and https://bugzilla.mozilla.org/show_bug.cgi?id=1724645",
{ id: "discourse.upload-debugging" }
);
return;
}
this._uppyInstance.on("upload", (data) => { this._uppyInstance.on("upload", (data) => {
data.fileIDs.forEach((fileId) => data.fileIDs.forEach((fileId) =>
performance.mark(`upload-${fileId}-start`) performance.mark(`upload-${fileId}-start`)