IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: Only scrollIntoView if sidebar items are not already visible (#28372)

Browse Source 
When browsing through a sidebar with this feature enabled (i.e. admin, or docs), it's weird to have the scroll jump around when you click an item. This commit adds a check, so that we only `scrollIntoView` for items which are not already in the viewport.

Followup to b7cce1a0dc
This commit is contained in:
David Taylor 2024-08-14 15:58:11 +01:00 committed by GitHub
parent f6fadd7129
commit ede6220347
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/discourse/app/components/sidebar/section-link.gjs
View File

@ -115,14 +115,22 @@ export default class SectionLink extends Component {
@bind @bind
maybeScrollIntoView(element) { maybeScrollIntoView(element) {
if (this.args.scrollIntoView) { if (!this.args.scrollIntoView) {
return;
}
schedule("afterRender", () => { schedule("afterRender", () => {
const rect = element.getBoundingClientRect();
const alreadyVisible = rect.top <= window.innerHeight && rect.bottom >= 0;
if (alreadyVisible) {
return;
}
element.scrollIntoView({ element.scrollIntoView({
block: "center", block: "center",
}); });
}); });
} }
}
<template> <template>
{{#if this.shouldDisplay}} {{#if this.shouldDisplay}}