IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Make max number of favorite configurable (#13480)

Browse Source 
It used to be hardcoded to 2 and now it uses max_favorite_badges site
setting. When zero, it disables favorite badges.
This commit is contained in:
Bianca Nenciu
2021-06-22 18:58:03 +03:00
committed by GitHub
parent e0e1e24c14
commit ee87d8c93b
13 changed files with 40 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/requests/user_badges_controller_spec.rb
View File

@@ -277,12 +277,18 @@ describe UserBadgesController do
expect(response.status).to eq(403)
end
it "checks that the user has less than two favorited badges" do
it "checks that the user has less than max_favorites_badges favorited badges" do
sign_in(user)
UserBadge.create(badge: Fabricate(:badge), user: user, granted_by: Discourse.system_user, granted_at: Time.now, is_favorite: true)
UserBadge.create(badge: Fabricate(:badge), user: user, granted_by: Discourse.system_user, granted_at: Time.now, is_favorite: true)
put "/user_badges/#{user_badge.id}/toggle_favorite.json"
expect(response.status).to eq(400)
SiteSetting.max_favorite_badges = 3
put "/user_badges/#{user_badge.id}/toggle_favorite.json"
expect(response.status).to eq(200)
end
it "favorites a badge" do