IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: include both name and id in color scheme stylesheet filename slugs (#10397)

Browse Source
This commit is contained in:
Penar Musaraj
2020-08-07 13:43:45 -04:00
committed by GitHub
parent 07dc5b5269
commit f179510a68
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spec/components/stylesheet/manager_spec.rb
View File

@@ -193,12 +193,13 @@ describe Stylesheet::Manager do
SiteSetting.default_theme_id = theme.id
link = Stylesheet::Manager.color_scheme_stylesheet_link_tag()
expect(link).to include("/stylesheets/color_definitions_funky_")
expect(link).to include("/stylesheets/color_definitions_funky#{cs.id}_")
end
it "uses the correct scheme when colors are passed" do
link = Stylesheet::Manager.color_scheme_stylesheet_link_tag(ColorScheme.first.id)
expect(link).to include("/stylesheets/color_definitions_#{Slug.for(ColorScheme.first.name)}_")
slug = Slug.for(ColorScheme.first.name) + ColorScheme.first.id.to_s
expect(link).to include("/stylesheets/color_definitions_#{slug}_")
end
it "does not fail with a color scheme name containing spaces and special characters" do
@@ -207,7 +208,7 @@ describe Stylesheet::Manager do
SiteSetting.default_theme_id = theme.id
link = Stylesheet::Manager.color_scheme_stylesheet_link_tag()
expect(link).to include("/stylesheets/color_definitions_funky-bunch_")
expect(link).to include("/stylesheets/color_definitions_funky-bunch#{cs.id}_")
end
end