From f297517055cfbc4a91dcc6582dc2a495d3651bee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Hanol?= <regis@hanol.fr>
Date: Fri, 20 Jun 2014 19:05:14 +0200
Subject: [PATCH] BUGFIX: prevent invisible topic from being pinned or becoming
 a banner

---
 .../templates/topic_admin_menu.js.handlebars  | 34 +++++++++++--------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/app/assets/javascripts/discourse/templates/topic_admin_menu.js.handlebars b/app/assets/javascripts/discourse/templates/topic_admin_menu.js.handlebars
index 78a5e645bdd..2f628dde722 100644
--- a/app/assets/javascripts/discourse/templates/topic_admin_menu.js.handlebars
+++ b/app/assets/javascripts/discourse/templates/topic_admin_menu.js.handlebars
@@ -29,22 +29,26 @@
       </li>
 
       {{#unless isPrivateMessage}}
-        <li>
-          {{#if isBanner}}
-            <button {{action removeBanner}} class='btn btn-admin'><i class='fa fa-bullhorn'></i> {{i18n topic.actions.remove_banner}}</button>
-          {{else}}
-            <button {{action makeBanner}} class='btn btn-admin'><i class='fa fa-bullhorn'></i> {{i18n topic.actions.make_banner}}</button>
-          {{/if}}
-        </li>
+          <li>
+            {{#if isBanner}}
+              <button {{action removeBanner}} class='btn btn-admin'><i class='fa fa-bullhorn'></i> {{i18n topic.actions.remove_banner}}</button>
+            {{else}}
+              {{#if visible}}
+                <button {{action makeBanner}} class='btn btn-admin'><i class='fa fa-bullhorn'></i> {{i18n topic.actions.make_banner}}</button>
+              {{/if}}
+            {{/if}}
+          </li>
 
-        <li>
-          {{#if pinned_at}}
-            <button {{action togglePinned}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.unpin}}</button>
-          {{else}}
-            <button {{action togglePinned}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.pin}}</button>
-            <button {{action togglePinnedGlobally}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.pin_globally}}</button>
-          {{/if}}
-        </li>
+          <li>
+            {{#if pinned_at}}
+              <button {{action togglePinned}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.unpin}}</button>
+            {{else}}
+              {{#if visible}}
+                <button {{action togglePinned}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.pin}}</button>
+                <button {{action togglePinnedGlobally}} class='btn btn-admin'><i class='fa fa-thumb-tack'></i> {{i18n topic.actions.pin_globally}}</button>
+              {{/if}}
+            {{/if}}
+          </li>
       {{/unless}}
 
       <li>