DEV: Use method definition syntax consistently (#14915)

2025-02-25 18:55:32 -06:00 · 2021-11-13 14:01:55 +01:00
parent bdd2c888b0
commit f414d5eace
66 changed files with 109 additions and 109 deletions
--- a/app/assets/javascripts/admin/addon/components/admin-backups-logs.js
+++ b/app/assets/javascripts/admin/addon/components/admin-backups-logs.js
@@ -33,7 +33,7 @@ export default Component.extend({
    }
  },

-  _updateFormattedLogsFunc: function () {
+  _updateFormattedLogsFunc() {
    const logs = this.logs;
    if (logs.length === 0) {
      return;
--- a/app/assets/javascripts/admin/addon/components/admin-theme-editor.js
+++ b/app/assets/javascripts/admin/addon/components/admin-theme-editor.js
@@ -114,7 +114,7 @@ export default Component.extend({
      this.fieldAdded(this.currentTargetName, name);
    },

-    toggleMaximize: function () {
+    toggleMaximize() {
      this.toggleProperty("maximized");
      next(() => this.appEvents.trigger("ace:resize"));
    },
--- a/app/assets/javascripts/admin/addon/components/color-input.js
+++ b/app/assets/javascripts/admin/addon/components/color-input.js
@@ -40,7 +40,7 @@ export default Component.extend({
  },

  @observes("hexValue", "brightnessValue", "valid")
-  hexValueChanged: function () {
+  hexValueChanged() {
    const hex = this.hexValue;
    let text = this.element.querySelector("input.hex-input");

--- a/app/assets/javascripts/admin/addon/controllers/admin-badges-show.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-badges-show.js
@@ -70,7 +70,7 @@ export default Controller.extend(bufferedProperty("model"), {
  },

  @observes("model.id")
-  _resetSaving: function () {
+  _resetSaving() {
    this.set("saving", false);
    this.set("savingStatus", "");
  },
--- a/app/assets/javascripts/admin/addon/controllers/admin-customize-colors-show.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-customize-colors-show.js
@@ -15,11 +15,11 @@ export default Controller.extend({
  },

  actions: {
-    revert: function (color) {
+    revert(color) {
      color.revert();
    },

-    undo: function (color) {
+    undo(color) {
      color.undo();
    },

@@ -68,7 +68,7 @@ export default Controller.extend({
      });
    },

-    save: function () {
+    save() {
      this.model.save();
    },

@@ -76,7 +76,7 @@ export default Controller.extend({
      this.model.updateUserSelectable(this.get("model.user_selectable"));
    },

-    destroy: function () {
+    destroy() {
      const model = this.model;
      return bootbox.confirm(
        I18n.t("admin.customize.colors.delete_confirm"),
--- a/app/assets/javascripts/admin/addon/controllers/admin-customize-themes-edit.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-customize-themes-edit.js
@@ -12,7 +12,7 @@ export default Controller.extend({
  editRouteName: "adminCustomizeThemes.edit",
  showRouteName: "adminCustomizeThemes.show",

-  setTargetName: function (name) {
+  setTargetName(name) {
    const target = this.get("model.targets").find((t) => t.name === name);
    this.set("currentTarget", target && target.id);
  },
--- a/app/assets/javascripts/admin/addon/controllers/admin-email-index.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-email-index.js
@@ -19,7 +19,7 @@ export default Controller.extend({
    @method testEmailAddressChanged
  **/
  @observes("testEmailAddress")
-  testEmailAddressChanged: function () {
+  testEmailAddressChanged() {
    this.set("sentTestEmail", false);
  },

@@ -29,7 +29,7 @@ export default Controller.extend({

      @method sendTestEmail
    **/
-    sendTestEmail: function () {
+    sendTestEmail() {
      this.setProperties({
        sendingEmail: true,
        sentTestEmail: false,
--- a/app/assets/javascripts/admin/addon/controllers/admin-permalinks.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-permalinks.js
@@ -37,7 +37,7 @@ export default Controller.extend({
      textArea.remove();
    },

-    destroy: function (record) {
+    destroy(record) {
      return bootbox.confirm(
        I18n.t("admin.permalink.delete_confirm"),
        I18n.t("no_value"),
--- a/app/assets/javascripts/admin/addon/controllers/admin-plugins.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-plugins.js
@@ -3,7 +3,7 @@ import discourseComputed from "discourse-common/utils/decorators";

 export default Controller.extend({
  @discourseComputed
-  adminRoutes: function () {
+  adminRoutes() {
    return this.model
      .map((p) => {
        if (p.get("enabled")) {
--- a/app/assets/javascripts/admin/addon/controllers/admin-user-badges.js
+++ b/app/assets/javascripts/admin/addon/controllers/admin-user-badges.js
@@ -61,7 +61,7 @@ export default Controller.extend(GrantBadgeController, {
  },

  actions: {
-    expandGroup: function (userBadge) {
+    expandGroup(userBadge) {
      const model = this.model;
      model.set("expandedBadges", model.get("expandedBadges") || []);
      model.get("expandedBadges").pushObject(userBadge.badge.id);
--- a/app/assets/javascripts/admin/addon/models/email-settings.js
+++ b/app/assets/javascripts/admin/addon/models/email-settings.js
@@ -4,7 +4,7 @@ import { ajax } from "discourse/lib/ajax";
 const EmailSettings = EmberObject.extend({});

 EmailSettings.reopenClass({
-  find: function () {
+  find() {
    return ajax("/admin/email.json").then(function (settings) {
      return EmailSettings.create(settings);
    });
--- a/app/assets/javascripts/admin/addon/models/permalink.js
+++ b/app/assets/javascripts/admin/addon/models/permalink.js
@@ -5,7 +5,7 @@ import { ajax } from "discourse/lib/ajax";
 import discourseComputed from "discourse-common/utils/decorators";

 const Permalink = EmberObject.extend({
-  save: function () {
+  save() {
    return ajax("/admin/permalinks.json", {
      type: "POST",
      data: {
@@ -17,16 +17,16 @@ const Permalink = EmberObject.extend({
  },

  @discourseComputed("category_id")
-  category: function (category_id) {
+  category(category_id) {
    return Category.findById(category_id);
  },

  @discourseComputed("external_url")
-  linkIsExternal: function (external_url) {
+  linkIsExternal(external_url) {
    return !DiscourseURL.isInternal(external_url);
  },

-  destroy: function () {
+  destroy() {
    return ajax("/admin/permalinks/" + this.id + ".json", {
      type: "DELETE",
    });
@@ -34,7 +34,7 @@ const Permalink = EmberObject.extend({
 });

 Permalink.reopenClass({
-  findAll: function (filter) {
+  findAll(filter) {
    return ajax("/admin/permalinks.json", { data: { filter } }).then(function (
      permalinks
    ) {
--- a/app/assets/javascripts/admin/addon/models/screened-email.js
+++ b/app/assets/javascripts/admin/addon/models/screened-email.js
@@ -9,7 +9,7 @@ const ScreenedEmail = EmberObject.extend({
    return I18n.t("admin.logs.screened_actions." + action);
  },

-  clearBlock: function () {
+  clearBlock() {
    return ajax("/admin/logs/screened_emails/" + this.id, {
      type: "DELETE",
    });
@@ -17,7 +17,7 @@ const ScreenedEmail = EmberObject.extend({
 });

 ScreenedEmail.reopenClass({
-  findAll: function () {
+  findAll() {
    return ajax("/admin/logs/screened_emails.json").then(function (
      screened_emails
    ) {
--- a/app/assets/javascripts/admin/addon/models/screened-url.js
+++ b/app/assets/javascripts/admin/addon/models/screened-url.js
@@ -11,7 +11,7 @@ const ScreenedUrl = EmberObject.extend({
 });

 ScreenedUrl.reopenClass({
-  findAll: function () {
+  findAll() {
    return ajax("/admin/logs/screened_urls.json").then(function (
      screened_urls
    ) {
--- a/app/assets/javascripts/admin/addon/routes/admin-emojis.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-emojis.js
@@ -3,7 +3,7 @@ import EmberObject from "@ember/object";
 import { ajax } from "discourse/lib/ajax";

 export default DiscourseRoute.extend({
-  model: function () {
+  model() {
    return ajax("/admin/customize/emojis.json").then(function (emojis) {
      return emojis.map(function (emoji) {
        return EmberObject.create(emoji);
--- a/app/assets/javascripts/admin/addon/routes/admin-logs-index.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-logs-index.js
@@ -1,7 +1,7 @@
 import DiscourseRoute from "discourse/routes/discourse";

 export default DiscourseRoute.extend({
-  redirect: function () {
+  redirect() {
    this.transitionTo("adminLogs.staffActionLogs");
  },
 });
--- a/app/assets/javascripts/admin/addon/routes/admin-logs-screened-emails.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-logs-screened-emails.js
@@ -1,11 +1,11 @@
 import DiscourseRoute from "discourse/routes/discourse";

 export default DiscourseRoute.extend({
-  renderTemplate: function () {
+  renderTemplate() {
    this.render("admin/templates/logs/screened-emails", { into: "adminLogs" });
  },

-  setupController: function () {
+  setupController() {
    return this.controllerFor("adminLogsScreenedEmails").show();
  },
 });
--- a/app/assets/javascripts/admin/addon/routes/admin-logs-screened-urls.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-logs-screened-urls.js
@@ -1,11 +1,11 @@
 import DiscourseRoute from "discourse/routes/discourse";

 export default DiscourseRoute.extend({
-  renderTemplate: function () {
+  renderTemplate() {
    this.render("admin/templates/logs/screened-urls", { into: "adminLogs" });
  },

-  setupController: function () {
+  setupController() {
    return this.controllerFor("adminLogsScreenedUrls").show();
  },
 });
--- a/app/assets/javascripts/admin/addon/routes/admin-user-fields.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-user-fields.js
@@ -2,11 +2,11 @@ import DiscourseRoute from "discourse/routes/discourse";
 import UserField from "admin/models/user-field";

 export default DiscourseRoute.extend({
-  model: function () {
+  model() {
    return this.store.findAll("user-field");
  },

-  setupController: function (controller, model) {
+  setupController(controller, model) {
    controller.setProperties({ model, fieldTypes: UserField.fieldTypes() });
  },
 });
--- a/app/assets/javascripts/admin/addon/routes/admin-users-index.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-users-index.js
@@ -1,7 +1,7 @@
 import DiscourseRoute from "discourse/routes/discourse";

 export default DiscourseRoute.extend({
-  redirect: function () {
+  redirect() {
    this.transitionTo("adminUsersList");
  },
 });
--- a/app/assets/javascripts/admin/addon/routes/admin-users-list-index.js
+++ b/app/assets/javascripts/admin/addon/routes/admin-users-list-index.js
@@ -1,7 +1,7 @@
 import DiscourseRoute from "discourse/routes/discourse";

 export default DiscourseRoute.extend({
-  beforeModel: function () {
+  beforeModel() {
    this.transitionTo("adminUsersList.show", "active");
  },
 });