DEV: Remove usages of enable_personal_messages (#18437)

cf. e62e93f83a

This PR also makes it so `bot` (negative ID) and `system` users are always allowed
to send PMs, since the old conditional was just based on `enable_personal_messages`
This commit is contained in:
Martin Brennan
2022-10-05 10:50:20 +10:00
committed by GitHub
parent 2d391565e4
commit f5194aadd3
28 changed files with 117 additions and 46 deletions
+5 -4
View File
@@ -583,10 +583,10 @@ RSpec.describe Search do
end
context 'with personal-direct and group_messages flags' do
let(:current) { Fabricate(:user, admin: true, username: "current_user") }
let(:participant) { Fabricate(:user, username: "participant_1") }
let(:participant_2) { Fabricate(:user, username: "participant_2") }
let(:non_participant) { Fabricate(:user, username: "non_participant") }
let!(:current) { Fabricate(:user, admin: true, username: "current_user") }
let!(:participant) { Fabricate(:user, username: "participant_1") }
let!(:participant_2) { Fabricate(:user, username: "participant_2") }
let!(:non_participant) { Fabricate(:user, username: "non_participant") }
let(:group) do
group = Fabricate(:group, has_messages: true)
@@ -596,6 +596,7 @@ RSpec.describe Search do
end
def create_pm(users:, group: nil)
Group.refresh_automatic_groups!
pm = Fabricate(:private_message_post_one_user, user: users.first).topic
users[1..-1].each do |u|
pm.invite(users.first, u.username)