mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FIX: ensures period-chooser is not losing query params (#10534)
eg repro before: - visit http://pr-discourse.test/top/weekly?f=foo - select another period in the period chooser - f=foo was gone After this commit it should still be present
This commit is contained in:
@@ -1,3 +1,5 @@
|
||||
import DiscourseURL from "discourse/lib/url";
|
||||
import selectKit from "helpers/select-kit-helper";
|
||||
import { acceptance } from "helpers/qunit-helpers";
|
||||
import MessageBus from "message-bus-client";
|
||||
|
||||
@@ -107,3 +109,22 @@ QUnit.test("Live update unread state", async assert => {
|
||||
"shows the topic read"
|
||||
);
|
||||
});
|
||||
|
||||
QUnit.test(
|
||||
"Using period chooser when query params are present",
|
||||
async assert => {
|
||||
await visit("/top?f=foo&d=bar");
|
||||
|
||||
sandbox.stub(DiscourseURL, "routeTo");
|
||||
|
||||
const periodChooser = selectKit(".period-chooser");
|
||||
|
||||
await periodChooser.expand();
|
||||
await periodChooser.selectRowByValue("yearly");
|
||||
|
||||
assert.ok(
|
||||
DiscourseURL.routeTo.calledWith("/top/yearly?f=foo&d=bar"),
|
||||
"it keeps the query params"
|
||||
);
|
||||
}
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user