From f76d88063d6b850b07ffb9a25c9dcc3eadb13750 Mon Sep 17 00:00:00 2001 From: Keegan George Date: Fri, 14 Feb 2025 09:50:42 -0800 Subject: [PATCH] FIX: Missing link to deleted post in `/my/deleted-posts` (#31342) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 🔍 Overview A regression in https://github.com/discourse/discourse/pull/30604, resulted in the title/link for deleted posts not being shown. This fix ensures that the title is once again shown. ## 📸 Screenshots ### ← Before ![Screenshot 2025-02-13 at 14 14 08](https://github.com/user-attachments/assets/17da8119-e476-4458-bc19-3f55efac91b2) ### → After ![Screenshot 2025-02-13 at 14 13 42](https://github.com/user-attachments/assets/ba2389ba-6cad-4641-a2cb-d2a13c10c233) --- .../javascripts/discourse/app/routes/user-deleted-posts.js | 2 +- .../discourse/tests/acceptance/user-deleted-posts-test.js | 7 +++++++ app/assets/javascripts/discourse/tests/fixtures/post.js | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/routes/user-deleted-posts.js b/app/assets/javascripts/discourse/app/routes/user-deleted-posts.js index 3833d75aa9d..a013a590154 100644 --- a/app/assets/javascripts/discourse/app/routes/user-deleted-posts.js +++ b/app/assets/javascripts/discourse/app/routes/user-deleted-posts.js @@ -21,7 +21,7 @@ export default class UserDeletedPosts extends DiscourseRoute { model.content.forEach((item) => { if (item.title) { - item.set("title", emojiUnescape(escapeExpression(item.title))); + item.set("titleHtml", emojiUnescape(escapeExpression(item.title))); } }); } diff --git a/app/assets/javascripts/discourse/tests/acceptance/user-deleted-posts-test.js b/app/assets/javascripts/discourse/tests/acceptance/user-deleted-posts-test.js index f3fbf7c0898..1eb2ea6202c 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/user-deleted-posts-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/user-deleted-posts-test.js @@ -26,4 +26,11 @@ acceptance("User's deleted posts page", function (needs) { .dom(".user-stream-item [data-topic-id='34']") .hasText("Another topic's text"); }); + + test("Displays the posts with the correct links", async function (assert) { + await visit(`/u/eviltrout/deleted-posts`); + assert + .dom(".user-stream-item .title") + .hasText("Localization of UI elements"); + }); }); diff --git a/app/assets/javascripts/discourse/tests/fixtures/post.js b/app/assets/javascripts/discourse/tests/fixtures/post.js index 98ef857d7e8..9a75e4288a0 100644 --- a/app/assets/javascripts/discourse/tests/fixtures/post.js +++ b/app/assets/javascripts/discourse/tests/fixtures/post.js @@ -32,6 +32,7 @@ export default { can_wiki: true, read: true, user_title: null, + title: "Private message to you", actions_summary: [ { id: 3, @@ -92,6 +93,7 @@ export default { can_delete: false, can_recover: true, user_title: null, + title: "Localization of UI elements", raw: "Any plans to support localization of UI elements, so that I (for example) could set up a completely German speaking forum?", actions_summary: [ { id: 2, count: 0, hidden: false, can_act: true },