From f8d9f093707f138c6672c42fe4dc884be1d65a9a Mon Sep 17 00:00:00 2001 From: Rafael dos Santos Silva Date: Mon, 15 Mar 2021 11:58:53 -0300 Subject: [PATCH] FEATURE: Fallback to system users when creating new TopicEmbed (#12386) Previosly, if the topic embed request had a missing username parameter, and SiteSetting.embed_by_username was empty we would fail to create the new topic and not show any errors. Now we will fallback using the priority: 1. Username parameter 2. SiteSetting.embed_by_username 3. SiteSetting.site_contact_username 4. system user --- lib/topic_retriever.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/topic_retriever.rb b/lib/topic_retriever.rb index a865143ce66..88d4d7c8e7a 100644 --- a/lib/topic_retriever.rb +++ b/lib/topic_retriever.rb @@ -41,7 +41,7 @@ class TopicRetriever def fetch_http if @author_username.nil? - username = SiteSetting.embed_by_username.downcase + username = SiteSetting.embed_by_username.presence || SiteSetting.site_contact_username.presence || Discourse.system_user.username else username = @author_username end