DEV: TODO followups (#18936)

* Remove old bookmark column ignores to follow up b22450c7a8
* Change some group site setting checks to use the _map helper
* Remove old secure_media helper stub for chat
* Change attr_accessor to attr_reader for preloaded_custom_fields to follow up 70af45055a
This commit is contained in:
Martin Brennan
2022-11-09 07:48:05 +10:00
committed by GitHub
parent 74a9859a12
commit f8f55cef67
6 changed files with 29 additions and 20 deletions

View File

@@ -64,9 +64,7 @@ module HasCustomFields
has_many :_custom_fields, dependent: :destroy, class_name: "#{name}CustomField"
after_save :save_custom_fields
# TODO (martin) Post 2.8 release, change to attr_reader because this is
# set by set_preloaded_custom_fields
attr_accessor :preloaded_custom_fields
attr_reader :preloaded_custom_fields
def custom_fields_fk
@custom_fields_fk ||= "#{_custom_fields.reflect_on_all_associations(:belongs_to)[0].name}_id"