IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

PERF: stop firing superfluous onSelectionChange

Browse Source 
onSelectionChanged fires a debounced event that calls window.getSelection()

window.getSelection() is reasonably expensive. There is no reason to do any
of this work if we have an input field focused, that is not how quote works
This commit is contained in:
Sam Saffron
2020-04-23 17:51:23 +10:00
parent 7132c50f3b
commit fa96054acf
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/discourse/components/quote-button.js
View File

@@ -188,10 +188,16 @@ export default Component.extend({
.on("mouseup.quote-button", () => { .on("mouseup.quote-button", () => {
this._prevSelection = null; this._prevSelection = null;
this._isMouseDown = false; this._isMouseDown = false;
onSelectionChanged(); if (document.activeElement === document.body) {
onSelectionChanged();
}
}) })
.on("selectionchange.quote-button", () => { .on("selectionchange.quote-button", () => {
if (!this._isMouseDown && !this._reselected) { if (
!this._isMouseDown &&
!this._reselected &&
document.activeElement === document.body
) {
onSelectionChanged(); onSelectionChanged();
} }
}); });