IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

remove "track external right clicks" feature

Browse Source
This commit is contained in:
Arpit Jalan
2018-07-29 14:26:24 +05:30
parent 3dbaaf0d74
commit fc3b904e1f
8 changed files with 9 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/javascripts/helpers/site-settings.js
View File

@@ -7,7 +7,6 @@ Discourse.SiteSettingsOriginal = {
"favicon_url":"//meta.discourse.org/uploads/default/2499/79d53726406d87af.ico",
"allow_user_locale":false,
"suggested_topics":7,
"track_external_right_clicks":false,
"ga_universal_tracking_code":"",
"ga_universal_domain_name":"auto",
"top_menu":"latest|new|unread|categories|top",

35
test/javascripts/lib/click-track-edit-history-test.js.es6
View File

@@ -103,41 +103,6 @@ asyncTestDiscourse("restores the href after a while", function(assert) {
}, 75);
});
var trackRightClick = function(target) {
var clickEvent = generateClickEventOn(target);
clickEvent.which = 3;
return track(clickEvent);
};
QUnit.test("right clicks change the href", assert => {
assert.ok(trackRightClick("a"));
assert.equal(
fixture("a")
.first()
.prop("href"),
"http://www.google.com/"
);
});
QUnit.test("right clicks are tracked", assert => {
Discourse.SiteSettings.track_external_right_clicks = true;
trackRightClick("a");
assert.equal(
fixture("a")
.first()
.attr("href"),
"/clicks/track?url=http%3A%2F%2Fwww.google.com&post_id=42&topic_id=1337"
);
});
QUnit.test("preventDefault is not called for right clicks", assert => {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
sandbox.stub(clickEvent, "preventDefault");
assert.ok(track(clickEvent));
assert.ok(!clickEvent.preventDefault.calledOnce);
});
var testOpenInANewTab = function(description, clickEventModifier) {
test(description, function(assert) {
var clickEvent = generateClickEventOn("a");

46
test/javascripts/lib/click-track-profile-page-test.js.es6
View File

@@ -97,52 +97,6 @@ asyncTestDiscourse("restores the href after a while", function(assert) {
}, 75);
});
var trackRightClick = function(target) {
var clickEvent = generateClickEventOn(target);
clickEvent.which = 3;
return track(clickEvent);
};
QUnit.test("right clicks change the href", assert => {
assert.ok(trackRightClick("a"));
assert.equal(
fixture("a")
.first()
.prop("href"),
"http://www.google.com/"
);
});
QUnit.test("right clicks are tracked", assert => {
Discourse.SiteSettings.track_external_right_clicks = true;
trackRightClick("a");
assert.equal(
fixture(".first a")
.first()
.attr("href"),
"/clicks/track?url=http%3A%2F%2Fwww.google.com&post_id=42&topic_id=1337"
);
});
QUnit.test("right clicks are tracked for second excerpt", assert => {
Discourse.SiteSettings.track_external_right_clicks = true;
trackRightClick(".second a");
assert.equal(
fixture(".second a")
.first()
.attr("href"),
"/clicks/track?url=http%3A%2F%2Fwww.google.com&post_id=24&topic_id=7331"
);
});
QUnit.test("preventDefault is not called for right clicks", assert => {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
sandbox.stub(clickEvent, "preventDefault");
assert.ok(track(clickEvent));
assert.ok(!clickEvent.preventDefault.calledOnce);
});
var testOpenInANewTab = function(description, clickEventModifier) {
test(description, function(assert) {
var clickEvent = generateClickEventOn("a");

35
test/javascripts/lib/click-track-test.js.es6
View File

@@ -132,41 +132,6 @@ QUnit.test("updates badge counts correctly", function(assert) {
badgeClickCount(assert, "with-badge", 2);
});
var trackRightClick = function() {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
return track(clickEvent);
};
QUnit.test("right clicks change the href", function(assert) {
assert.ok(trackRightClick());
assert.equal(
fixture("a")
.first()
.prop("href"),
"http://www.google.com/"
);
});
QUnit.test("right clicks are tracked", function(assert) {
Discourse.SiteSettings.track_external_right_clicks = true;
trackRightClick();
assert.equal(
fixture("a")
.first()
.attr("href"),
"/clicks/track?url=http%3A%2F%2Fwww.google.com&post_id=42&topic_id=1337"
);
});
QUnit.test("preventDefault is not called for right clicks", function(assert) {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
sandbox.stub(clickEvent, "preventDefault");
assert.ok(track(clickEvent));
assert.ok(!clickEvent.preventDefault.calledOnce);
});
var testOpenInANewTab = function(description, clickEventModifier) {
test(description, function(assert) {
var clickEvent = generateClickEventOn("a");