mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 02:40:53 -06:00
FIX: page:changed was sometimes reporting the wrong URL
(This change could be considered a little risky so we should keep an eye on it.) The core issue here is that sometimes as far as the router was concerned we had transitioned to a route even if a Topic model was still in the process of loading. In this case the callback could not retrieve the correct title yet because it had not loaded. This fix returns a promise from `setupController` when visiting a topic, which will have the router block until the topic is loaded. This means that the transition never triggers until the topic title is present. Note: adding a test for this is basically impossible - it was super hard to reproduce even in a browser.
This commit is contained in:
parent
69efbd213b
commit
fc63f0d316
@ -33,7 +33,7 @@ export default DiscourseRoute.extend({
|
||||
|
||||
params.forceLoad = true;
|
||||
|
||||
postStream
|
||||
return postStream
|
||||
.refresh(params)
|
||||
.then(() => {
|
||||
// TODO we are seeing errors where closest post is null and this is exploding
|
||||
|
Loading…
Reference in New Issue
Block a user