IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-13 06:25:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: do not show private group flair on user avatars (#13872)

Browse Source 
Meta ref: https://meta.discourse.org/t/visible-flair-for-invisible-groups-is-that-on-purpose/167674
This commit is contained in:
Arpit Jalan
2021-08-02 06:21:00 +05:30
committed by GitHub
parent 2d02ae36b5
commit fe3e18f981
6 changed files with 51 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/models/group_spec.rb
+8
View File
@@ -1307,4 +1307,12 @@ describe Group do
expect(Group.find_by_email("nope@test.com")).to eq(nil)
end
end
it "fetches flair_url based on group visibility" do
public_group = Fabricate(:group, flair_icon: "icon", visibility_level: Group.visibility_levels[:public], members_visibility_level: Group.visibility_levels[:public])
private_group = Fabricate(:group, flair_icon: "icon", visibility_level: Group.visibility_levels[:logged_on_users], members_visibility_level: Group.visibility_levels[:public])
expect(public_group.flair_url).to eq("icon")
expect(private_group.flair_url).to eq(nil)
end
end