From ff8e1f4ed63c7c2ae6c767227eb9f46bc6083d37 Mon Sep 17 00:00:00 2001
From: Jan Cernik <66427541+jancernik@users.noreply.github.com>
Date: Tue, 30 Apr 2024 11:47:36 -0500
Subject: [PATCH] FIX: Do not show topic admin menu button to regular users
 (#26820)

---
 .../app/components/topic-admin-menu.gjs       | 451 +++++++++---------
 1 file changed, 236 insertions(+), 215 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs b/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
index e185e31de15..2546907524f 100644
--- a/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-admin-menu.gjs
@@ -72,240 +72,261 @@ export default class TopicAdminMenu extends Component {
     return getURL(`/review?topic_id=${this.args.topic.id}&status=all`);
   }
 
-  <template>
-    <span class="topic-admin-menu-button-container">
-      <span class="topic-admin-menu-button">
-        <DMenu
-          @onRegisterApi={{this.onRegisterApi}}
-          @triggerClass="toggle-admin-menu"
-          @modalForMobile={{true}}
-        >
-          <:trigger>
-            {{icon "wrench"}}
-          </:trigger>
-          <:content>
-            <div class="popup-menu topic-admin-popup-menu">
-              <ul>
-                <ul class="topic-admin-menu-topic">
-                  {{#if
-                    (or
-                      this.currentUser.canManageTopic
-                      this.details.can_split_merge_topic
-                    )
-                  }}
-                    <li class="topic-admin-multi-select">
-                      <DButton
-                        class="btn-transparent"
-                        @label="topic.actions.multi_select"
-                        @action={{fn this.onButtonAction "toggleMultiSelect"}}
-                        @icon="tasks"
-                      />
-                    </li>
-                  {{/if}}
+  get showAdminButton() {
+    return (
+      this.currentUser?.canManageTopic ||
+      this.details?.can_archive_topic ||
+      this.details?.can_close_topic
+    );
+  }
 
-                  {{#if
-                    (or
-                      this.currentUser.canManageTopic
-                      this.details.can_moderate_category
-                    )
-                  }}
-                    {{#if this.canDelete}}
-                      <li class="topic-admin-delete">
-                        <DButton
-                          @label="topic.actions.delete"
-                          @action={{fn this.onButtonAction "deleteTopic"}}
-                          @icon="far-trash-alt"
-                          class="popup-menu-btn-danger btn-danger btn-transparent"
-                        />
-                      </li>
-                    {{else if this.canRecover}}
-                      <li class="topic-admin-recover">
+  <template>
+    {{#if this.showAdminButton}}
+      <span class="topic-admin-menu-button-container">
+        <span class="topic-admin-menu-button">
+          <DMenu
+            @onRegisterApi={{this.onRegisterApi}}
+            @triggerClass="toggle-admin-menu"
+            @modalForMobile={{true}}
+          >
+            <:trigger>
+              {{icon "wrench"}}
+            </:trigger>
+            <:content>
+              <div class="popup-menu topic-admin-popup-menu">
+                <ul>
+                  <ul class="topic-admin-menu-topic">
+                    {{#if
+                      (or
+                        this.currentUser.canManageTopic
+                        this.details.can_split_merge_topic
+                      )
+                    }}
+                      <li class="topic-admin-multi-select">
                         <DButton
                           class="btn-transparent"
-                          @label="topic.actions.recover"
-                          @action={{fn this.onButtonAction "recoverTopic"}}
-                          @icon="undo"
+                          @label="topic.actions.multi_select"
+                          @action={{fn this.onButtonAction "toggleMultiSelect"}}
+                          @icon="tasks"
                         />
                       </li>
                     {{/if}}
-                  {{/if}}
 
-                  {{#if this.details.can_close_topic}}
-                    <li
-                      class={{if
-                        @topic.closed
-                        "topic-admin-open"
-                        "topic-admin-close"
-                      }}
-                    >
-                      <DButton
-                        class="btn-transparent"
-                        @label={{if
+                    {{#if
+                      (or
+                        this.currentUser.canManageTopic
+                        this.details.can_moderate_category
+                      )
+                    }}
+                      {{#if this.canDelete}}
+                        <li class="topic-admin-delete">
+                          <DButton
+                            @label="topic.actions.delete"
+                            @action={{fn this.onButtonAction "deleteTopic"}}
+                            @icon="far-trash-alt"
+                            class="popup-menu-btn-danger btn-danger btn-transparent"
+                          />
+                        </li>
+                      {{else if this.canRecover}}
+                        <li class="topic-admin-recover">
+                          <DButton
+                            class="btn-transparent"
+                            @label="topic.actions.recover"
+                            @action={{fn this.onButtonAction "recoverTopic"}}
+                            @icon="undo"
+                          />
+                        </li>
+                      {{/if}}
+                    {{/if}}
+
+                    {{#if this.details.can_close_topic}}
+                      <li
+                        class={{if
                           @topic.closed
-                          "topic.actions.open"
-                          "topic.actions.close"
+                          "topic-admin-open"
+                          "topic-admin-close"
                         }}
-                        @action={{fn this.onButtonAction "toggleClosed"}}
-                        @icon={{if @topic.closed "unlock" "lock"}}
-                      />
-                    </li>
-                  {{/if}}
-
-                  {{#if
-                    (and
-                      this.details.can_pin_unpin_topic
-                      (not this.isPrivateMessage)
-                      (or this.visible this.featured)
-                    )
-                  }}
-                    <li class="topic-admin-pin">
-                      <DButton
-                        class="btn-transparent"
-                        @label={{if
-                          this.featured
-                          "topic.actions.unpin"
-                          "topic.actions.pin"
-                        }}
-                        @action={{fn this.onButtonAction "showFeatureTopic"}}
-                        @icon="thumbtack"
-                      />
-                    </li>
-                  {{/if}}
-
-                  {{#if
-                    (and
-                      this.details.can_archive_topic (not this.isPrivateMessage)
-                    )
-                  }}
-                    <li class="topic-admin-archive">
-                      <DButton
-                        class="btn-transparent"
-                        @label={{if
-                          this.archived
-                          "topic.actions.unarchive"
-                          "topic.actions.archive"
-                        }}
-                        @action={{fn this.onButtonAction "toggleArchived"}}
-                        @icon="folder"
-                      />
-                    </li>
-                  {{/if}}
-
-                  {{#if this.details.can_toggle_topic_visibility}}
-                    <li class="topic-admin-visible">
-                      <DButton
-                        class="btn-transparent"
-                        @label={{if
-                          this.visible
-                          "topic.actions.invisible"
-                          "topic.actions.visible"
-                        }}
-                        @action={{fn this.onButtonAction "toggleVisibility"}}
-                        @icon={{if this.visible "far-eye-slash" "far-eye"}}
-                      />
-                    </li>
-                  {{/if}}
-
-                  {{#if (and this.details.can_convert_topic)}}
-                    <li class="topic-admin-convert">
-                      <DButton
-                        class="btn-transparent"
-                        @label={{if
-                          this.isPrivateMessage
-                          "topic.actions.make_public"
-                          "topic.actions.make_private"
-                        }}
-                        @action={{fn
-                          this.onButtonAction
-                          (if
-                            this.isPrivateMessage
-                            "convertToPublicTopic"
-                            "convertToPrivateMessage"
-                          )
-                        }}
-                        @icon={{if this.isPrivateMessage "comment" "envelope"}}
-                      />
-                    </li>
-                  {{/if}}
-                </ul>
-
-                <ul class="topic-admin-menu-time">
-                  {{#if this.currentUser.canManageTopic}}
-                    <li class="admin-topic-timer-update">
-                      <DButton
-                        class="btn-transparent"
-                        @label="topic.actions.timed_update"
-                        @action={{fn this.onButtonAction "showTopicTimerModal"}}
-                        @icon="far-clock"
-                      />
-                    </li>
-
-                    {{#if this.currentUser.staff}}
-                      <li class="topic-admin-change-timestamp">
+                      >
                         <DButton
                           class="btn-transparent"
-                          @label="topic.change_timestamp.title"
+                          @label={{if
+                            @topic.closed
+                            "topic.actions.open"
+                            "topic.actions.close"
+                          }}
+                          @action={{fn this.onButtonAction "toggleClosed"}}
+                          @icon={{if @topic.closed "unlock" "lock"}}
+                        />
+                      </li>
+                    {{/if}}
+
+                    {{#if
+                      (and
+                        this.details.can_pin_unpin_topic
+                        (not this.isPrivateMessage)
+                        (or this.visible this.featured)
+                      )
+                    }}
+                      <li class="topic-admin-pin">
+                        <DButton
+                          class="btn-transparent"
+                          @label={{if
+                            this.featured
+                            "topic.actions.unpin"
+                            "topic.actions.pin"
+                          }}
+                          @action={{fn this.onButtonAction "showFeatureTopic"}}
+                          @icon="thumbtack"
+                        />
+                      </li>
+                    {{/if}}
+
+                    {{#if
+                      (and
+                        this.details.can_archive_topic
+                        (not this.isPrivateMessage)
+                      )
+                    }}
+                      <li class="topic-admin-archive">
+                        <DButton
+                          class="btn-transparent"
+                          @label={{if
+                            this.archived
+                            "topic.actions.unarchive"
+                            "topic.actions.archive"
+                          }}
+                          @action={{fn this.onButtonAction "toggleArchived"}}
+                          @icon="folder"
+                        />
+                      </li>
+                    {{/if}}
+
+                    {{#if this.details.can_toggle_topic_visibility}}
+                      <li class="topic-admin-visible">
+                        <DButton
+                          class="btn-transparent"
+                          @label={{if
+                            this.visible
+                            "topic.actions.invisible"
+                            "topic.actions.visible"
+                          }}
+                          @action={{fn this.onButtonAction "toggleVisibility"}}
+                          @icon={{if this.visible "far-eye-slash" "far-eye"}}
+                        />
+                      </li>
+                    {{/if}}
+
+                    {{#if (and this.details.can_convert_topic)}}
+                      <li class="topic-admin-convert">
+                        <DButton
+                          class="btn-transparent"
+                          @label={{if
+                            this.isPrivateMessage
+                            "topic.actions.make_public"
+                            "topic.actions.make_private"
+                          }}
                           @action={{fn
                             this.onButtonAction
-                            "showChangeTimestamp"
+                            (if
+                              this.isPrivateMessage
+                              "convertToPublicTopic"
+                              "convertToPrivateMessage"
+                            )
                           }}
-                          @icon="calendar-alt"
+                          @icon={{if
+                            this.isPrivateMessage
+                            "comment"
+                            "envelope"
+                          }}
+                        />
+                      </li>
+                    {{/if}}
+                  </ul>
+
+                  <ul class="topic-admin-menu-time">
+                    {{#if this.currentUser.canManageTopic}}
+                      <li class="admin-topic-timer-update">
+                        <DButton
+                          class="btn-transparent"
+                          @label="topic.actions.timed_update"
+                          @action={{fn
+                            this.onButtonAction
+                            "showTopicTimerModal"
+                          }}
+                          @icon="far-clock"
+                        />
+                      </li>
+
+                      {{#if this.currentUser.staff}}
+                        <li class="topic-admin-change-timestamp">
+                          <DButton
+                            class="btn-transparent"
+                            @label="topic.change_timestamp.title"
+                            @action={{fn
+                              this.onButtonAction
+                              "showChangeTimestamp"
+                            }}
+                            @icon="calendar-alt"
+                          />
+                        </li>
+                      {{/if}}
+
+                      <li class="topic-admin-reset-bump-date">
+                        <DButton
+                          class="btn-transparent"
+                          @label="topic.actions.reset_bump_date"
+                          @action={{fn this.onButtonAction "resetBumpDate"}}
+                          @icon="anchor"
+                        />
+                      </li>
+
+                      <li class="topic-admin-slow-mode">
+                        <DButton
+                          class="btn-transparent"
+                          @label="topic.actions.slow_mode"
+                          @action={{fn
+                            this.onButtonAction
+                            "showTopicSlowModeUpdate"
+                          }}
+                          @icon="hourglass-start"
+                        />
+                      </li>
+                    {{/if}}
+                  </ul>
+
+                  <ul class="topic-admin-menu-undefined">
+                    {{#if this.currentUser.staff}}
+                      <li class="topic-admin-moderation-history">
+                        <DButton
+                          class="btn-transparent"
+                          @label="review.moderation_history"
+                          @href={{this.topicModerationHistoryUrl}}
+                          @icon="list"
                         />
                       </li>
                     {{/if}}
 
-                    <li class="topic-admin-reset-bump-date">
-                      <DButton
-                        class="btn-transparent"
-                        @label="topic.actions.reset_bump_date"
-                        @action={{fn this.onButtonAction "resetBumpDate"}}
-                        @icon="anchor"
-                      />
-                    </li>
-
-                    <li class="topic-admin-slow-mode">
-                      <DButton
-                        class="btn-transparent"
-                        @label="topic.actions.slow_mode"
-                        @action={{fn
-                          this.onButtonAction
-                          "showTopicSlowModeUpdate"
-                        }}
-                        @icon="hourglass-start"
-                      />
-                    </li>
-                  {{/if}}
+                    {{#each this.extraButtons as |button|}}
+                      <li>
+                        <DButton
+                          @label={{button.label}}
+                          @translatedLabel={{button.translatedLabel}}
+                          @icon={{button.icon}}
+                          class={{concatClass
+                            "btn-transparent"
+                            button.className
+                          }}
+                          @action={{fn this.onExtraButtonAction button.action}}
+                        />
+                      </li>
+                    {{/each}}
+                  </ul>
                 </ul>
-
-                <ul class="topic-admin-menu-undefined">
-                  {{#if this.currentUser.staff}}
-                    <li class="topic-admin-moderation-history">
-                      <DButton
-                        class="btn-transparent"
-                        @label="review.moderation_history"
-                        @href={{this.topicModerationHistoryUrl}}
-                        @icon="list"
-                      />
-                    </li>
-                  {{/if}}
-
-                  {{#each this.extraButtons as |button|}}
-                    <li>
-                      <DButton
-                        @label={{button.label}}
-                        @translatedLabel={{button.translatedLabel}}
-                        @icon={{button.icon}}
-                        class={{concatClass "btn-transparent" button.className}}
-                        @action={{fn this.onExtraButtonAction button.action}}
-                      />
-                    </li>
-                  {{/each}}
-                </ul>
-              </ul>
-            </div>
-          </:content>
-        </DMenu>
+              </div>
+            </:content>
+          </DMenu>
+        </span>
       </span>
-    </span>
+    {{/if}}
   </template>
 }