From ffc163419327f8f7a317c90123244d53c2b87e85 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 17 Apr 2014 13:01:44 -0400 Subject: [PATCH] FIX: Only show link clicks on the title of a onebox, not repeatedly in its body. --- app/assets/javascripts/discourse/lib/click_track.js | 2 +- app/assets/javascripts/discourse/views/post_view.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/lib/click_track.js b/app/assets/javascripts/discourse/lib/click_track.js index afe2456776c..207a8f31998 100644 --- a/app/assets/javascripts/discourse/lib/click_track.js +++ b/app/assets/javascripts/discourse/lib/click_track.js @@ -41,7 +41,7 @@ Discourse.ClickTrack = { // don't update counts in category badge if ($link.closest('.badge-category').length === 0) { // nor in oneboxes (except when we force it) - if ($link.closest(".onebox-result").length === 0 || $link.hasClass("track-link")) { + if (($link.closest(".onebox-result").length === 0 && $link.closest('.onebox-body').length === 0) || $link.hasClass("track-link")) { var html = $badge.html(); if (/^\d+$/.test(html)) { $badge.html(parseInt(html, 10) + 1); diff --git a/app/assets/javascripts/discourse/views/post_view.js b/app/assets/javascripts/discourse/views/post_view.js index 1cc74946f72..fad7483913b 100644 --- a/app/assets/javascripts/discourse/views/post_view.js +++ b/app/assets/javascripts/discourse/views/post_view.js @@ -139,7 +139,7 @@ Discourse.PostView = Discourse.GroupedView.extend(Ember.Evented, { var link = $(this); if (link.attr('href') === lc.url) { // don't display badge counts on category badge - if (link.closest('.badge-category').length === 0 && (link.closest(".onebox-result").length === 0 || link.hasClass("track-link"))) { + if (link.closest('.badge-category').length === 0 && ((link.closest(".onebox-result").length === 0 && link.closest('.onebox-body').length === 0) || link.hasClass("track-link"))) { link.append("" + Discourse.Formatter.number(lc.clicks) + "");